From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09DF33B5830; Thu, 12 Mar 2026 15:54:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.92.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773330873; cv=none; b=n+1p8aoGtiERH6XNeh4C8LvljKvCgkupPA9jxmG4jU12LXghG3vnNskqysU34wiyaSH6KtGniJ18vt86qGD4MPZRcOAgVAEmmWuUMOVmxENABHt5KiJWIYjN7vQaECdaZwUxSVFdfru1dJ6V4YyDZj+FbH1vBjKCCycJDnF6Hoc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773330873; c=relaxed/simple; bh=vlTgds1DWS3jGqCfYHFILlvQj6g5aLpvbOAdG84ObyI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bXbUc+4fLfaxDpKrMupYcEB7JguT0ss3BcvOmEwE5G7Lrc8M7vLER6OMGJxNxsp21iC83vX9CPQNK+GMysznyPwppFfIsAW7YB2I2HHpbRQVuzZABqd6B6Gb6AUGWyag7W4iMBe/InKX+pemfjOABzSFcjM2U9Uuy39Qf1qtilE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=X0043a9Z; arc=none smtp.client-ip=90.155.92.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="X0043a9Z" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=J91GOtlULKSH0FD7uF5RTiGJtASwj8AkgmOe2gJa2aA=; b=X0043a9ZKmQ5lGEE/t+XcPXFVN jM7ZyVnJzwZCmV+Zph8ti/BGxxXp59cn+7UjXHQnCcs6XNV84+tCSlLfbeNPFj2Zj2h7LFxX6oEnc FnFHUpqkRZW4EZ2R1SgXnDyAv9sJ3YzPnrAjcKHTjKulEsLuD7KnCJc+FC+BaWW/MMBfx0AEwSlSV VY05Jj+AW+eqnZ0pt4QkRZ1YWlM81rkx+hhROS50f4HrizvygY2gRYDep3A/B3jh+n0k1HpRdnhxE ixlMP1y3J5SzEHoWl4dv/SfcGuqj01VmwaMxErjIBFTwGp4SA4KvkVOR6h7bOB0ld/zvCw2HH1+J/ LBFQr7oA==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1w0iMn-00000001WNG-3QpJ; Thu, 12 Mar 2026 15:54:29 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 5586730049C; Thu, 12 Mar 2026 16:54:29 +0100 (CET) Date: Thu, 12 Mar 2026 16:54:29 +0100 From: Peter Zijlstra To: Mathieu Desnoyers Cc: Steven Rostedt , "Vineeth Pillai (Google)" , Dmitry Ilvokhin , Masami Hiramatsu , Ingo Molnar , Jens Axboe , io-uring@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Marcelo Ricardo Leitner , Xin Long , Jon Maloy , Aaron Conole , Eelco Chaudron , Ilya Maximets , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-sctp@vger.kernel.org, tipc-discussion@lists.sourceforge.net, dev@openvswitch.org, Oded Gabbay , Koby Elbaz , dri-devel@lists.freedesktop.org, "Rafael J. Wysocki" , Viresh Kumar , "Gautham R. Shenoy" , Huang Rui , Mario Limonciello , Len Brown , Srinivas Pandruvada , linux-pm@vger.kernel.org, MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Christian =?iso-8859-1?Q?K=F6nig?= , Sumit Semwal , linaro-mm-sig@lists.linaro.org, Eddie James , Andrew Jeffery , Joel Stanley , linux-fsi@lists.ozlabs.org, David Airlie , Simona Vetter , Alex Deucher , Danilo Krummrich , Matthew Brost , Philipp Stanner , Harry Wentland , Leo Li , amd-gfx@lists.freedesktop.org, Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org, Wolfram Sang , linux-i2c@vger.kernel.org, Mark Brown , Michael Hennerich , Nuno =?iso-8859-1?Q?S=E1?= , linux-spi@vger.kernel.org, "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, Chris Mason , David Sterba , linux-btrfs@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/15] tracepoint: Avoid double static_branch evaluation at guarded call sites Message-ID: <20260312155429.GC1282955@noisy.programming.kicks-ass.net> References: <20260312150523.2054552-1-vineeth@bitbyteword.org> <1e3c2830-765e-4271-89f7-0b6784b37597@efficios.com> <20260312112354.3dd99e36@gandalf.local.home> <219d015d-076b-4c80-8f63-88569115fdad@efficios.com> <20260312114041.5193c729@gandalf.local.home> <1becdbce-2c01-468a-bbab-42b5dea9fdf8@efficios.com> Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1becdbce-2c01-468a-bbab-42b5dea9fdf8@efficios.com> On Thu, Mar 12, 2026 at 11:49:23AM -0400, Mathieu Desnoyers wrote: > On 2026-03-12 11:40, Steven Rostedt wrote: > > On Thu, 12 Mar 2026 11:28:07 -0400 > > Mathieu Desnoyers wrote: > > > > > > Note, Vineeth came up with the naming. I would have done "do" but when I > > > > saw "invoke" I thought it sounded better. > > > > > > It works as long as you don't have a tracing subsystem called > > > "invoke", then you get into identifier clash territory. > > > > True. Perhaps we should do the double underscore trick. > > > > Instead of: trace_invoke_foo() > > > > use: trace_invoke__foo() > > > > > > Which will make it more visible to what the trace event is. > > > > Hmm, we probably should have used: trace__foo() for all tracepoints, as > > there's still functions that are called trace_foo() that are not > > tracepoints :-p > > One certain way to eliminate identifier clash would be to go for a > prefix to "trace_", e.g. Oh, I know!, call them __do_trace_##foo(). /me runs like hell