From: Yang Xiuwei <yangxiuwei@kylinos.cn>
To: axboe@kernel.dk
Cc: io-uring@vger.kernel.org
Subject: Re: [PATCH 2/2] test/cbpf_filter: skip when openat2.h is not available
Date: Mon, 16 Mar 2026 09:02:54 +0800 [thread overview]
Message-ID: <20260316010254.63804-1-yangxiuwei@kylinos.cn> (raw)
In-Reply-To: <3ecf01a7-4057-423e-bafa-881454f6e014@kernel.dk>
Hi Jens,
On 2026-03-15 14:45 UTC, Jens Axboe wrote:
> I think just defining RESOLVE_IN_ROOT if it's not available should be
> fine. And yes the test will always compile when you stub everything out,
> but it also won't do anything at all. This will prevent running this
> test case on a host with old headers, but with a current kernel. How
> about the below, hopefully that should do it. That'll keep the test
> functional, rather than wrap it all in a define that just disables it
> entirely.
>
> diff --git a/test/cbpf_filter.c b/test/cbpf_filter.c
> ...
> +#ifndef RESOLVE_IN_ROOT
> +#define RESOLVE_IN_ROOT 0x10
> +#endif
Thanks, that works well for me. I'll send v2 with your approach.
Best regards,
Yang Xiuwei
prev parent reply other threads:[~2026-03-16 1:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-14 8:35 [PATCH Liburing 0/2] build and compiler warning fixes Yang Xiuwei
2026-03-14 8:35 ` [PATCH 1/2] examples/send-zerocopy: fix -Wstringop-truncation on ifr.ifr_name Yang Xiuwei
2026-03-14 8:35 ` [PATCH 2/2] test/cbpf_filter: skip when openat2.h is not available Yang Xiuwei
2026-03-14 13:35 ` Jens Axboe
2026-03-15 5:02 ` Yang Xiuwei
2026-03-15 14:45 ` Jens Axboe
2026-03-16 1:02 ` Yang Xiuwei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260316010254.63804-1-yangxiuwei@kylinos.cn \
--to=yangxiuwei@kylinos.cn \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox