From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30AA083A14 for ; Mon, 16 Mar 2026 01:03:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773623000; cv=none; b=TdgW1R6SQoOUuuo2x//z/yZaDlVeX2tWpzlPK8lCTimhxmUaZeJGpAMeX6KFIuiTyLGCuTctvg1SGkiKL4k+WEuyuZ1V2HG+wJKWzONzixhwMVofvmomOvqSsCUb+JG+I0FfYdXELKwY496MX37aZWIZScsPiy6nyNiJ6DRK7rw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773623000; c=relaxed/simple; bh=LnBDd4EKXqsBb5/31t5VJyegrPItwa0g8S7AZj4Xahw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Ec7cy+irIEVnWIc5TehxBW14+KQG7pnIMo1YUXa1xUXPXBpyG3GDgBMTitD9lLmqC8eUsWLCFkRW+KGZ2uiHBuaV+lPhTWWyBG2Jkv9Rhu9nghZVjiqxqwrvEHyTc677jnGZEgCmBAsTNkDuhSzC3jvsRvb0aAl0qwY6DsDHRt4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=CXxcdnDE; arc=none smtp.client-ip=117.135.210.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="CXxcdnDE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=MB EIDZP12fAfE2s6Be4A/vdNnYszauQdv1KIVnKd9i4=; b=CXxcdnDEXV5IlC6hWf Ns7MP5cRRVimrWMr/f1fwJwCNDuaRh/pdkjzSc7H1e38Bb+TvvAtG+fEtz2zQduB fkRyikeOLE/ptRgSJQRYRautgyjKCU/IXy2hoVdAeDWRAIIoG5UJXjFO1Ib1FwLf P5p7smunlPjZHbLCd9DPKUAnQ= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g1-4 (Coremail) with SMTP id _____wCn75bAVrdpqyTEAw--.0S2; Mon, 16 Mar 2026 09:03:04 +0800 (CST) From: Yang Xiuwei To: axboe@kernel.dk Cc: io-uring@vger.kernel.org Subject: Re: [PATCH 2/2] test/cbpf_filter: skip when openat2.h is not available Date: Mon, 16 Mar 2026 09:02:54 +0800 Message-Id: <20260316010254.63804-1-yangxiuwei@kylinos.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <3ecf01a7-4057-423e-bafa-881454f6e014@kernel.dk> References: <20260314083538.791693-1-yangxiuwei@kylinos.cn> <20260314083538.791693-3-yangxiuwei@kylinos.cn> <10b4b9bf-2dc8-41f3-bed2-110170dff236@kernel.dk> <20260315050217.121292-1-yangxiuwei@kylinos.cn> <3ecf01a7-4057-423e-bafa-881454f6e014@kernel.dk> Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:_____wCn75bAVrdpqyTEAw--.0S2 X-Coremail-Antispam: 1Uf129KBjvdXoWruF4kKw15GF1kGF18XFWrZrb_yoWxKrg_Wr 1vvr97Cr4DGF1xJrZ8Jr1DJFy7JFsavrn7Aw4rW3sxC34YyayYk3Z7Zrn7ZFnxC393G3Z0 9rn8tr1qyw12vjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRE7PEPUUUUU== Sender: yangxiuwei2025@163.com X-CM-SenderInfo: p1dqw55lxzvxisqskqqrwthudrp/xtbCwgkQoGm3VsmlFAAA3L Hi Jens, On 2026-03-15 14:45 UTC, Jens Axboe wrote: > I think just defining RESOLVE_IN_ROOT if it's not available should be > fine. And yes the test will always compile when you stub everything out, > but it also won't do anything at all. This will prevent running this > test case on a host with old headers, but with a current kernel. How > about the below, hopefully that should do it. That'll keep the test > functional, rather than wrap it all in a define that just disables it > entirely. > > diff --git a/test/cbpf_filter.c b/test/cbpf_filter.c > ... > +#ifndef RESOLVE_IN_ROOT > +#define RESOLVE_IN_ROOT 0x10 > +#endif Thanks, that works well for me. I'll send v2 with your approach. Best regards, Yang Xiuwei