From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F228DC433E3 for ; Thu, 16 Jul 2020 20:48:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B99F520787 for ; Thu, 16 Jul 2020 20:48:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S0tOe4di" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726691AbgGPUsx (ORCPT ); Thu, 16 Jul 2020 16:48:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725928AbgGPUsx (ORCPT ); Thu, 16 Jul 2020 16:48:53 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2B61C061755; Thu, 16 Jul 2020 13:48:52 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id f2so8516725wrp.7; Thu, 16 Jul 2020 13:48:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7Eqj9DsRh6gVjKvMX6P7OU0uqK/0x31oue4DPZYY3+g=; b=S0tOe4di3pZfE8TPqS58flVkFsQhYzhng0cSiQDKGIjcdgeSMR7S5LW6Il9mEg5BuA 6ssEZVX/DZ55nmVXu5sg1/dONujPNo7qLQWNwS7XedeNpvGSucBtkdxJGfNYuQhvAejT memNfb3cu+iZndxMDZL4I8d5SLlSjpIMwiQoYk0zZLGEn/yynwVA0QK3tlgW1W5k+Fg3 PMlcBaSI6AbNCErPQzcb0eJOHSmhARMxdcL8XdrqmSMZ3JFZCPBsQdXNM9ToSWrF8Yfr rfeX8m1HQjScgUoDg+UlFVQRUGBuFjMeNdcH5etrAweseZBY6kwgwsY18Q3dHAUcyo/5 7ZYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=7Eqj9DsRh6gVjKvMX6P7OU0uqK/0x31oue4DPZYY3+g=; b=KqCdwxMTNUXeCbHQH/wdswtfQOW9Hmma6IkY6hUYEM0OryIbl61nEVKQp7ZtLqgECp Tnzh2jHVFpnTEcxeESqrw7w/NGVfCobYCEY+Wpc2JAlYkdMNCL9f1dpd6VK6cf+GV0mw gHZGdHXlyVd0yQozuZuDKQNVFNTswwRZuVrrDBuq4ENUy5Dlp0Db3LcusDfFd+ww2DnX 5o/bDFBGhmXtwMy4VBT/p75oK4FnA+27f4Gch09Y14mtjG9J8HBiA8ROhKyNVsxd4IXo 0MRh9MR8TqYqPsA+LiM6H1mjVQaBQOR924YVRiRDVDcvQrjg/US82P1HYguq9JLUn402 sEDA== X-Gm-Message-State: AOAM532MF1yPMb5GEx0RbpPMKZ4nT9QzcsLS881qdcD7wJPG1myFWady C7iAAZdgtas1pUa/mJQP8JhJacCYukk= X-Google-Smtp-Source: ABdhPJxSyrX2dc7t67bKHYl2rtGuILeM/JLQ964R+5CqhEIiKTEr/FdbuU+wjHpp+kttqkIpy6uF5A== X-Received: by 2002:adf:ab46:: with SMTP id r6mr6746372wrc.260.1594932531211; Thu, 16 Jul 2020 13:48:51 -0700 (PDT) Received: from [192.168.43.238] ([5.100.193.69]) by smtp.gmail.com with ESMTPSA id 26sm9824289wmj.25.2020.07.16.13.48.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jul 2020 13:48:50 -0700 (PDT) Subject: Re: [PATCH RFC v2 1/3] io_uring: use an enumeration for io_uring_register(2) opcodes To: Jens Axboe , Stefano Garzarella Cc: Alexander Viro , Kernel Hardening , Kees Cook , Aleksa Sarai , Stefan Hajnoczi , Christian Brauner , Sargun Dhillon , Jann Horn , io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jeff Moyer , linux-kernel@vger.kernel.org References: <20200716124833.93667-1-sgarzare@redhat.com> <20200716124833.93667-2-sgarzare@redhat.com> From: Pavel Begunkov Autocrypt: addr=asml.silence@gmail.com; prefer-encrypt=mutual; keydata= mQINBFmKBOQBEAC76ZFxLAKpDw0bKQ8CEiYJRGn8MHTUhURL02/7n1t0HkKQx2K1fCXClbps bdwSHrhOWdW61pmfMbDYbTj6ZvGRvhoLWfGkzujB2wjNcbNTXIoOzJEGISHaPf6E2IQx1ik9 6uqVkK1OMb7qRvKH0i7HYP4WJzYbEWVyLiAxUj611mC9tgd73oqZ2pLYzGTqF2j6a/obaqha +hXuWTvpDQXqcOZJXIW43atprH03G1tQs7VwR21Q1eq6Yvy2ESLdc38EqCszBfQRMmKy+cfp W3U9Mb1w0L680pXrONcnlDBCN7/sghGeMHjGKfNANjPc+0hzz3rApPxpoE7HC1uRiwC4et83 CKnncH1l7zgeBT9Oa3qEiBlaa1ZCBqrA4dY+z5fWJYjMpwI1SNp37RtF8fKXbKQg+JuUjAa9 Y6oXeyEvDHMyJYMcinl6xCqCBAXPHnHmawkMMgjr3BBRzODmMr+CPVvnYe7BFYfoajzqzq+h EyXSl3aBf0IDPTqSUrhbmjj5OEOYgRW5p+mdYtY1cXeK8copmd+fd/eTkghok5li58AojCba jRjp7zVOLOjDlpxxiKhuFmpV4yWNh5JJaTbwCRSd04sCcDNlJj+TehTr+o1QiORzc2t+N5iJ NbILft19Izdn8U39T5oWiynqa1qCLgbuFtnYx1HlUq/HvAm+kwARAQABtDFQYXZlbCBCZWd1 bmtvdiAoc2lsZW5jZSkgPGFzbWwuc2lsZW5jZUBnbWFpbC5jb20+iQJOBBMBCAA4FiEE+6Ju PTjTbx479o3OWt5b1Glr+6UFAlmKBOQCGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQ Wt5b1Glr+6WxZA//QueaKHzgdnOikJ7NA/Vq8FmhRlwgtP0+E+w93kL+ZGLzS/cUCIjn2f4Q Mcutj2Neg0CcYPX3b2nJiKr5Vn0rjJ/suiaOa1h1KzyNTOmxnsqE5fmxOf6C6x+NKE18I5Jy xzLQoktbdDVA7JfB1itt6iWSNoOTVcvFyvfe5ggy6FSCcP+m1RlR58XxVLH+qlAvxxOeEr/e aQfUzrs7gqdSd9zQGEZo0jtuBiB7k98t9y0oC9Jz0PJdvaj1NZUgtXG9pEtww3LdeXP/TkFl HBSxVflzeoFaj4UAuy8+uve7ya/ECNCc8kk0VYaEjoVrzJcYdKP583iRhOLlZA6HEmn/+Gh9 4orG67HNiJlbFiW3whxGizWsrtFNLsSP1YrEReYk9j1SoUHHzsu+ZtNfKuHIhK0sU07G1OPN 2rDLlzUWR9Jc22INAkhVHOogOcc5ajMGhgWcBJMLCoi219HlX69LIDu3Y34uIg9QPZIC2jwr 24W0kxmK6avJr7+n4o8m6sOJvhlumSp5TSNhRiKvAHB1I2JB8Q1yZCIPzx+w1ALxuoWiCdwV M/azguU42R17IuBzK0S3hPjXpEi2sK/k4pEPnHVUv9Cu09HCNnd6BRfFGjo8M9kZvw360gC1 reeMdqGjwQ68o9x0R7NBRrtUOh48TDLXCANAg97wjPoy37dQE7e5Ag0EWYoE5AEQAMWS+aBV IJtCjwtfCOV98NamFpDEjBMrCAfLm7wZlmXy5I6o7nzzCxEw06P2rhzp1hIqkaab1kHySU7g dkpjmQ7Jjlrf6KdMP87mC/Hx4+zgVCkTQCKkIxNE76Ff3O9uTvkWCspSh9J0qPYyCaVta2D1 Sq5HZ8WFcap71iVO1f2/FEHKJNz/YTSOS/W7dxJdXl2eoj3gYX2UZNfoaVv8OXKaWslZlgqN jSg9wsTv1K73AnQKt4fFhscN9YFxhtgD/SQuOldE5Ws4UlJoaFX/yCoJL3ky2kC0WFngzwRF Yo6u/KON/o28yyP+alYRMBrN0Dm60FuVSIFafSqXoJTIjSZ6olbEoT0u17Rag8BxnxryMrgR dkccq272MaSS0eOC9K2rtvxzddohRFPcy/8bkX+t2iukTDz75KSTKO+chce62Xxdg62dpkZX xK+HeDCZ7gRNZvAbDETr6XI63hPKi891GeZqvqQVYR8e+V2725w+H1iv3THiB1tx4L2bXZDI DtMKQ5D2RvCHNdPNcZeldEoJwKoA60yg6tuUquvsLvfCwtrmVI2rL2djYxRfGNmFMrUDN1Xq F3xozA91q3iZd9OYi9G+M/OA01husBdcIzj1hu0aL+MGg4Gqk6XwjoSxVd4YT41kTU7Kk+/I 5/Nf+i88ULt6HanBYcY/+Daeo/XFABEBAAGJAjYEGAEIACAWIQT7om49ONNvHjv2jc5a3lvU aWv7pQUCWYoE5AIbDAAKCRBa3lvUaWv7pfmcEACKTRQ28b1y5ztKuLdLr79+T+LwZKHjX++P 4wKjEOECCcB6KCv3hP+J2GCXDOPZvdg/ZYZafqP68Yy8AZqkfa4qPYHmIdpODtRzZSL48kM8 LRzV8Rl7J3ItvzdBRxf4T/Zseu5U6ELiQdCUkPGsJcPIJkgPjO2ROG/ZtYa9DvnShNWPlp+R uPwPccEQPWO/NP4fJl2zwC6byjljZhW5kxYswGMLBwb5cDUZAisIukyAa8Xshdan6C2RZcNs rB3L7vsg/R8UCehxOH0C+NypG2GqjVejNZsc7bgV49EOVltS+GmGyY+moIzxsuLmT93rqyII 5rSbbcTLe6KBYcs24XEoo49Zm9oDA3jYvNpeYD8rDcnNbuZh9kTgBwFN41JHOPv0W2FEEWqe JsCwQdcOQ56rtezdCJUYmRAt3BsfjN3Jn3N6rpodi4Dkdli8HylM5iq4ooeb5VkQ7UZxbCWt UVMKkOCdFhutRmYp0mbv2e87IK4erwNHQRkHUkzbsuym8RVpAZbLzLPIYK/J3RTErL6Z99N2 m3J6pjwSJY/zNwuFPs9zGEnRO4g0BUbwGdbuvDzaq6/3OJLKohr5eLXNU3JkT+3HezydWm3W OPhauth7W0db74Qd49HXK0xe/aPrK+Cp+kU1HRactyNtF8jZQbhMCC8vMGukZtWaAwpjWiiH bA== Message-ID: <20326d79-fb5a-2480-e52a-e154e056171f@gmail.com> Date: Thu, 16 Jul 2020 23:47:03 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: io-uring-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 16/07/2020 23:42, Jens Axboe wrote: > On 7/16/20 2:16 PM, Pavel Begunkov wrote: >> On 16/07/2020 15:48, Stefano Garzarella wrote: >>> The enumeration allows us to keep track of the last >>> io_uring_register(2) opcode available. >>> >>> Behaviour and opcodes names don't change. >>> >>> Signed-off-by: Stefano Garzarella >>> --- >>> include/uapi/linux/io_uring.h | 27 ++++++++++++++++----------- >>> 1 file changed, 16 insertions(+), 11 deletions(-) >>> >>> diff --git a/include/uapi/linux/io_uring.h b/include/uapi/linux/io_uring.h >>> index 7843742b8b74..efc50bd0af34 100644 >>> --- a/include/uapi/linux/io_uring.h >>> +++ b/include/uapi/linux/io_uring.h >>> @@ -253,17 +253,22 @@ struct io_uring_params { >>> /* >>> * io_uring_register(2) opcodes and arguments >>> */ >>> -#define IORING_REGISTER_BUFFERS 0 >>> -#define IORING_UNREGISTER_BUFFERS 1 >>> -#define IORING_REGISTER_FILES 2 >>> -#define IORING_UNREGISTER_FILES 3 >>> -#define IORING_REGISTER_EVENTFD 4 >>> -#define IORING_UNREGISTER_EVENTFD 5 >>> -#define IORING_REGISTER_FILES_UPDATE 6 >>> -#define IORING_REGISTER_EVENTFD_ASYNC 7 >>> -#define IORING_REGISTER_PROBE 8 >>> -#define IORING_REGISTER_PERSONALITY 9 >>> -#define IORING_UNREGISTER_PERSONALITY 10 >>> +enum { >>> + IORING_REGISTER_BUFFERS, >>> + IORING_UNREGISTER_BUFFERS, >>> + IORING_REGISTER_FILES, >>> + IORING_UNREGISTER_FILES, >>> + IORING_REGISTER_EVENTFD, >>> + IORING_UNREGISTER_EVENTFD, >>> + IORING_REGISTER_FILES_UPDATE, >>> + IORING_REGISTER_EVENTFD_ASYNC, >>> + IORING_REGISTER_PROBE, >>> + IORING_REGISTER_PERSONALITY, >>> + IORING_UNREGISTER_PERSONALITY, >>> + >>> + /* this goes last */ >>> + IORING_REGISTER_LAST >>> +}; >> >> It breaks userspace API. E.g. >> >> #ifdef IORING_REGISTER_BUFFERS > > It can, yes, but we have done that in the past. In this one, for Ok, if nobody on the userspace side cares, then better to do that sooner than later. > example: > > commit 9e3aa61ae3e01ce1ce6361a41ef725e1f4d1d2bf (tag: io_uring-5.5-20191212) > Author: Jens Axboe > Date: Wed Dec 11 15:55:43 2019 -0700 > > io_uring: ensure we return -EINVAL on unknown opcod > > But it would be safer/saner to do this like we have the done the IOSQE_ > flags. IOSQE_ are a bitmask, but this would look peculiar enum { __IORING_REGISTER_BUFFERS, ... }; define IORING_REGISTER_BUFFERS __IORING_REGISTER_BUFFERS -- Pavel Begunkov