From: Jens Axboe <axboe@kernel.dk>
To: io-uring@vger.kernel.org,
Michael Bommarito <michael.bommarito@gmail.com>
Cc: Pavel Begunkov <asml.silence@gmail.com>,
Li Zetao <lizetao1@huawei.com>,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] io_uring: propagate array_index_nospec opcode into req->opcode
Date: Sat, 16 May 2026 13:06:42 -0600 [thread overview]
Message-ID: <21a2b88f-ec94-46df-b018-8a027689c38e@kernel.dk> (raw)
In-Reply-To: <177895835722.925638.5480075990608035864.b4-ty@b4>
On 5/16/26 1:05 PM, Jens Axboe wrote:
>
> On Fri, 15 May 2026 10:58:11 -0400, Michael Bommarito wrote:
>> Commit 1e988c3fe126 ("io_uring: prevent opcode speculation") added
>> array_index_nospec() to the local opcode in io_init_req(), but the
>> sanitised value is not written back to req->opcode. The
>> unconditional write at the top of io_init_req() stores the raw byte
>> into the persistent field; the success path of the bounds check
>> leaves it unchanged, and downstream consumers read the raw value.
>>
>> [...]
>
> Applied, thanks!
>
> [1/1] io_uring: propagate array_index_nospec opcode into req->opcode
> (no commit info)
Oops, was just applied for review, nothing has been applied. Awaiting
a v2 based on the feedback.
--
Jens Axboe
prev parent reply other threads:[~2026-05-16 19:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 14:58 [PATCH] io_uring: propagate array_index_nospec opcode into req->opcode Michael Bommarito
2026-05-15 15:45 ` Keith Busch
2026-05-15 15:47 ` Jens Axboe
2026-05-15 15:46 ` Jens Axboe
2026-05-16 19:05 ` Jens Axboe
2026-05-16 19:06 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21a2b88f-ec94-46df-b018-8a027689c38e@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizetao1@huawei.com \
--cc=michael.bommarito@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox