From: Jens Axboe <[email protected]>
To: Pavel Begunkov <[email protected]>,
[email protected],
Alexander Viro <[email protected]>,
linux-fsdevel <[email protected]>
Cc: Palash Oswal <[email protected]>,
Sudip Mukherjee <[email protected]>,
[email protected],
[email protected]
Subject: Re: [PATCH v2 0/2] iter revert problems
Date: Mon, 16 Aug 2021 09:35:12 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 8/12/21 2:40 PM, Pavel Begunkov wrote:
> For the bug description see 2/2. As mentioned there the current problems
> is because of generic_write_checks(), but there was also a similar case
> fixed in 5.12, which should have been triggerable by normal
> write(2)/read(2) and others.
>
> It may be better to enforce reexpands as a long term solution, but for
> now this patchset is quickier and easier to backport.
>
> v2: don't fail it has been justly fully reverted
Al, what do you think of this approach? It'll fix the issue, but might be
cleaner to have iov->truncated actually track the truncated size. That'd
make it a more complete solution, at the expense of bloat iov_iter which
this version will not.
--
Jens Axboe
next prev parent reply other threads:[~2021-08-16 15:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 20:40 [PATCH v2 0/2] iter revert problems Pavel Begunkov
2021-08-12 20:40 ` [PATCH v2 1/2] iov_iter: mark truncated iters Pavel Begunkov
2021-08-12 20:40 ` [PATCH v2 2/2] io_uring: don't retry with truncated iter Pavel Begunkov
2021-08-16 15:35 ` Jens Axboe [this message]
2021-08-21 14:24 ` [PATCH v2 0/2] iter revert problems Pavel Begunkov
2021-08-21 22:25 ` Al Viro
2021-08-21 23:13 ` Jens Axboe
2021-08-23 12:28 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox