public inbox for [email protected]
 help / color / mirror / Atom feed
From: Pavel Begunkov <[email protected]>
To: Ryan Sharpelletti <[email protected]>, [email protected]
Cc: [email protected]
Subject: Re: Potential corner case in release 5.8
Date: Wed, 7 Apr 2021 13:52:39 +0100	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+9Y6nxMg8W8P1-_56N8ArwHvT2EUippzwd0y_zNJ+O5Hvbw0Q@mail.gmail.com>

On 06/04/2021 18:53, Ryan Sharpelletti wrote:
> On Fri, Mar 5, 2021 at 2:07 PM Ryan Sharpelletti
> <[email protected]> wrote:
>> I suspect there is a corner case for io_uring in release 5.8.

Did you see any fail?

>> Can you please explain where the associated mmdrop/kthread_unuse_mm
>> calls for io_sq_thread_acquire_mm in io_init_req(...) are?

Look for io_sq_thread_drop_mm(). acquire_mm shouldn't do anything
unless it's SQPOLL mode and so executed by sqpoll task.

>> Specifically, what would happen if there was an error after calling
>> io_sq_thread_acquire_mm (for example, the -EINVAL a few lines after)?

Will be cleaned by io_sq_thread().

>>
>> From what I can understand, it looks like the kthread_unuse_mm and
>> mmput might be handled in the call to io_sq_thread_acquire_mm in
>> io_sq_thread. However, I am not seeing where mmdrop might be called.


-- 
Pavel Begunkov

      reply	other threads:[~2021-04-07 12:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-05 19:07 Potential corner case in release 5.8 Ryan Sharpelletti
2021-04-06 17:53 ` Ryan Sharpelletti
2021-04-07 12:52   ` Pavel Begunkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox