public inbox for [email protected]
 help / color / mirror / Atom feed
From: Olivier Langlois <[email protected]>
To: Stefan Metzmacher <[email protected]>,
	Pavel Begunkov <[email protected]>,
	Jens Axboe <[email protected]>,
	Steven Rostedt <[email protected]>,
	Ingo Molnar <[email protected]>,
	[email protected], [email protected]
Subject: Re: [PATCH] io_uring: Add to traces the req pointer when available
Date: Wed, 26 May 2021 13:19:27 -0400	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On Wed, 2021-05-26 at 12:18 -0400, Olivier Langlois wrote:
> > 
> > If that gets changed, could be also include the personality id and
> > flags here,
> > and maybe also translated the opcode and flags to human readable
> > strings?
> > 
> If Jens and Pavel agrees that they would like to see this info in the
> traces, I have no objection adding it.
> 
I need to learn to think longer before replying...

opcode in readable string:
If Jens and Pavel agrees to it, easy to add

flags:
You have my support that it is indeed a very useful info to have in the
submit_sqe trace when debugging with traces

flags in readable string:
After thinking about it, I wouldn't do it. Converting a bitmask of
flags into a string isn't that complex but it isn't trivial neither.
This certainly adds a maintenance burden every time the flags would be
updated. I wouldn't want that burden on my shoulders.



  reply	other threads:[~2021-05-26 17:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <[email protected]>
2021-05-25  8:21 ` [PATCH] io_uring: Add to traces the req pointer when available Pavel Begunkov
2021-05-25  8:33   ` Pavel Begunkov
2021-05-25 21:26     ` Olivier Langlois
2021-05-25 21:48       ` Olivier Langlois
2021-05-25 22:28         ` Jens Axboe
2021-05-26  8:28           ` Olivier Langlois
2021-05-25 21:29   ` Olivier Langlois
2021-05-26 12:38   ` Stefan Metzmacher
2021-05-26 16:18     ` Olivier Langlois
2021-05-26 17:19       ` Olivier Langlois [this message]
2021-05-29 12:18         ` Pavel Begunkov
2021-05-28 22:42       ` Steven Rostedt
2021-05-29 12:30         ` Pavel Begunkov
2021-05-29 12:34           ` Pavel Begunkov
2021-05-29 17:55           ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2285bf713be951917f9bec40f9cc45045990cc71.camel@trillion01.com \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox