public inbox for [email protected]
 help / color / mirror / Atom feed
* [PATCH] io_uring: rename __io_submit_sqe()
@ 2019-11-21 18:24 Pavel Begunkov
  2019-11-21 20:08 ` Jens Axboe
  2019-11-22  6:11 ` Bob Liu
  0 siblings, 2 replies; 5+ messages in thread
From: Pavel Begunkov @ 2019-11-21 18:24 UTC (permalink / raw)
  To: Jens Axboe, io-uring

__io_submit_sqe() is issuing requests, so call it as
such. Moreover, it ends by calling io_iopoll_req_issued().

Rename it and make terminology clearer.

Signed-off-by: Pavel Begunkov <[email protected]>
---
 fs/io_uring.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/io_uring.c b/fs/io_uring.c
index dd220f415c39..fa1cf7263959 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -2579,8 +2579,8 @@ static int io_req_defer(struct io_kiocb *req)
 	return -EIOCBQUEUED;
 }
 
-static int __io_submit_sqe(struct io_kiocb *req, struct io_kiocb **nxt,
-			   bool force_nonblock)
+static int io_issue_sqe(struct io_kiocb *req, struct io_kiocb **nxt,
+			bool force_nonblock)
 {
 	int ret, opcode;
 	struct sqe_submit *s = &req->submit;
@@ -2685,7 +2685,7 @@ static void io_wq_submit_work(struct io_wq_work **workptr)
 		s->has_user = (work->flags & IO_WQ_WORK_HAS_MM) != 0;
 		s->in_async = true;
 		do {
-			ret = __io_submit_sqe(req, &nxt, false);
+			ret = io_issue_sqe(req, &nxt, false);
 			/*
 			 * We can get EAGAIN for polled IO even though we're
 			 * forcing a sync submission from here, since we can't
@@ -2896,7 +2896,7 @@ static void __io_queue_sqe(struct io_kiocb *req)
 	struct io_kiocb *nxt = io_prep_linked_timeout(req);
 	int ret;
 
-	ret = __io_submit_sqe(req, NULL, true);
+	ret = io_issue_sqe(req, NULL, true);
 
 	/*
 	 * We async punt it if the file wasn't marked NOWAIT, or if the file
-- 
2.24.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-11-22  6:11 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-21 18:24 [PATCH] io_uring: rename __io_submit_sqe() Pavel Begunkov
2019-11-21 20:08 ` Jens Axboe
2019-11-21 20:30   ` Pavel Begunkov
2019-11-21 20:34     ` Jens Axboe
2019-11-22  6:11 ` Bob Liu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox