* [PATCH][next][V2] io_uring: Fix uninitialized variable up.resv
@ 2021-04-26 10:13 Colin King
2021-04-26 10:44 ` AW: " Walter Harms
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2021-04-26 10:13 UTC (permalink / raw)
To: Jens Axboe, Pavel Begunkov, io-uring; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <[email protected]>
The variable up.resv is not initialized and is being checking for a
non-zero value in the call to _io_register_rsrc_update. Fix this by
explicitly setting up.resv to 0.
Addresses-Coverity: ("Uninitialized scalar variable)"
Fixes: c3bdad027183 ("io_uring: add generic rsrc update with tags")
Signed-off-by: Colin Ian King <[email protected]>
Reviewed-by: Pavel Begunkov <[email protected]>
---
V2: replace "pointer" in commit message with "up.resv"
---
fs/io_uring.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/io_uring.c b/fs/io_uring.c
index f4ec092c23f4..63f610ee274b 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -5842,6 +5842,7 @@ static int io_files_update(struct io_kiocb *req, unsigned int issue_flags)
up.data = req->rsrc_update.arg;
up.nr = 0;
up.tags = 0;
+ up.resv = 0;
mutex_lock(&ctx->uring_lock);
ret = __io_register_rsrc_update(ctx, IORING_RSRC_FILE,
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* AW: [PATCH][next][V2] io_uring: Fix uninitialized variable up.resv
2021-04-26 10:13 [PATCH][next][V2] io_uring: Fix uninitialized variable up.resv Colin King
@ 2021-04-26 10:44 ` Walter Harms
0 siblings, 0 replies; 2+ messages in thread
From: Walter Harms @ 2021-04-26 10:44 UTC (permalink / raw)
To: Colin King, Jens Axboe, Pavel Begunkov, [email protected]
Cc: [email protected], [email protected]
why not:
struct io_uring_rsrc_update up={0};
would be future proof :)
jm2c,
re,
wh
________________________________________
Von: Colin King <[email protected]>
Gesendet: Montag, 26. April 2021 12:13:53
An: Jens Axboe; Pavel Begunkov; [email protected]
Cc: [email protected]; [email protected]
Betreff: [PATCH][next][V2] io_uring: Fix uninitialized variable up.resv
WARNUNG: Diese E-Mail kam von außerhalb der Organisation. Klicken Sie nicht auf Links oder öffnen Sie keine Anhänge, es sei denn, Sie kennen den/die Absender*in und wissen, dass der Inhalt sicher ist.
From: Colin Ian King <[email protected]>
The variable up.resv is not initialized and is being checking for a
non-zero value in the call to _io_register_rsrc_update. Fix this by
explicitly setting up.resv to 0.
Addresses-Coverity: ("Uninitialized scalar variable)"
Fixes: c3bdad027183 ("io_uring: add generic rsrc update with tags")
Signed-off-by: Colin Ian King <[email protected]>
Reviewed-by: Pavel Begunkov <[email protected]>
---
V2: replace "pointer" in commit message with "up.resv"
---
fs/io_uring.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/io_uring.c b/fs/io_uring.c
index f4ec092c23f4..63f610ee274b 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -5842,6 +5842,7 @@ static int io_files_update(struct io_kiocb *req, unsigned int issue_flags)
up.data = req->rsrc_update.arg;
up.nr = 0;
up.tags = 0;
+ up.resv = 0;
mutex_lock(&ctx->uring_lock);
ret = __io_register_rsrc_update(ctx, IORING_RSRC_FILE,
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-26 10:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-26 10:13 [PATCH][next][V2] io_uring: Fix uninitialized variable up.resv Colin King
2021-04-26 10:44 ` AW: " Walter Harms
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox