From: Jens Axboe <[email protected]>
To: Pavel Begunkov <[email protected]>, [email protected]
Subject: Re: [PATCH for-next] io_uring: fix io_free_batch_list races
Date: Tue, 12 Oct 2021 08:59:20 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <b1f4df38fbb8f111f52911a02fd418d0283a4e6f.1634047298.git.asml.silence@gmail.com>
On 10/12/21 8:02 AM, Pavel Begunkov wrote:
> [ 158.514382] WARNING: CPU: 5 PID: 15251 at fs/io_uring.c:1141 io_free_batch_list+0x269/0x360
> [ 158.514426] RIP: 0010:io_free_batch_list+0x269/0x360
> [ 158.514437] Call Trace:
> [ 158.514440] __io_submit_flush_completions+0xde/0x180
> [ 158.514444] tctx_task_work+0x14a/0x220
> [ 158.514447] task_work_run+0x64/0xa0
> [ 158.514448] __do_sys_io_uring_enter+0x7c/0x970
> [ 158.514450] __x64_sys_io_uring_enter+0x22/0x30
> [ 158.514451] do_syscall_64+0x43/0x90
> [ 158.514453] entry_SYSCALL_64_after_hwframe+0x44/0xae
>
> We should not touch request internals including req->comp_list.next
> after putting our ref if it's not final, e.g. we can start freeing
> requests from the free cache.
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2021-10-12 14:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 14:02 [PATCH for-next] io_uring: fix io_free_batch_list races Pavel Begunkov
2021-10-12 14:59 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox