* [PATCH liburing 1/1] tests/fd-pass: close rings
@ 2023-03-05 5:16 Pavel Begunkov
2023-03-05 14:35 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Pavel Begunkov @ 2023-03-05 5:16 UTC (permalink / raw)
To: io-uring; +Cc: Jens Axboe, asml.silence
Don't leak rings from test(), we call it several times and have a good
number of open rings lingering during the test for no good reason.
Signed-off-by: Pavel Begunkov <[email protected]>
---
test/fd-pass.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/test/fd-pass.c b/test/fd-pass.c
index 245495c..f3ede77 100644
--- a/test/fd-pass.c
+++ b/test/fd-pass.c
@@ -161,6 +161,8 @@ static int test(const char *filename, int source_fd, int target_fd)
if (verify_fixed_read(&dring, target_fd, 0))
return T_EXIT_FAIL;
+ io_uring_queue_exit(&sring);
+ io_uring_queue_exit(&dring);
return T_EXIT_PASS;
}
--
2.39.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH liburing 1/1] tests/fd-pass: close rings
2023-03-05 5:16 [PATCH liburing 1/1] tests/fd-pass: close rings Pavel Begunkov
@ 2023-03-05 14:35 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2023-03-05 14:35 UTC (permalink / raw)
To: io-uring, Pavel Begunkov
On Sun, 05 Mar 2023 05:16:57 +0000, Pavel Begunkov wrote:
> Don't leak rings from test(), we call it several times and have a good
> number of open rings lingering during the test for no good reason.
>
>
Applied, thanks!
[1/1] tests/fd-pass: close rings
commit: 3533273acbacdc5b120dce12d3aab5c8e56e6186
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-05 14:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-05 5:16 [PATCH liburing 1/1] tests/fd-pass: close rings Pavel Begunkov
2023-03-05 14:35 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox