From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33ABBC433E9 for ; Sat, 16 Jan 2021 19:35:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 07891229C4 for ; Sat, 16 Jan 2021 19:35:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726883AbhAPTfB (ORCPT ); Sat, 16 Jan 2021 14:35:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726864AbhAPTfA (ORCPT ); Sat, 16 Jan 2021 14:35:00 -0500 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10509C061573 for ; Sat, 16 Jan 2021 11:34:20 -0800 (PST) Received: by mail-wr1-x429.google.com with SMTP id 91so12630635wrj.7 for ; Sat, 16 Jan 2021 11:34:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ODLxMNDjnNxqeD+4tbydvAZTQHrz+YYuBxewsdi6T+0=; b=oyIVLyUUV19iP09KQr/t7yCb7RNHOn9ZwljtIS+Njvj8UUk/ztdrRb1JDrLv3B8Oyt 8mTps5ok81lr2myk2AHlTOUFACi+VIz4fjbULIJts4OlmJqOeZMAyLyu+9WxEiq3ZM4D 43zuEtqG7T0VrD8z/oGcBseRFBJe3AcblGbU1ZIGGIcK0hNqeJZP/E3Oi/R2POwKdfrR XheLzpXv33m835NMeSF4Neru/9DwLBUzrAgmd5cXBgELLU0ozYsYvcPBL6MENWtQaHDE ylNUmg55OrroOvqxQZmVIkvup+0YWfWr1MWXxESAhTkBwJbsCEEuOmeYG3waad0thFtu C1aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:autocrypt:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ODLxMNDjnNxqeD+4tbydvAZTQHrz+YYuBxewsdi6T+0=; b=I/pYKEsi9ZHcyx1Gcssl1yYgTVY+ynC7TLlikO0Qxoay9Z22+63+PcEvWHrafxxUlz 6920ron0lvG+eyKlVdG05nlQuZzYrFjB+yzv4fCpXFw+eTKO4y0BkxAKx5PEtpCPBNrz NmEq1mMIa7jGiVG0dmsQ0tC82vTFoitsIxaUYzd/XTgIAN7aldtdXHstt/7427wzzcX5 hMq+WXiMnuDAIUxRPeIZ08cKl2UYITVZT8zuV25slOG4dUeTg/JTlZzBUAO4/wDxVWBe QVxv88rvzmr/avBwhoNsiV1dBlcj0lB/VF3ppJ0dqIjXv0bhYISnKeRuMwn15No5EYky AwNQ== X-Gm-Message-State: AOAM530b/E2AkFnGyqZsXh/57H4YPaRqV8uTMjRuobXrU0lFaYkLJ0x8 EXfk0ZdqUG3Dd/iciJBxAgYJA4gc9ZY= X-Google-Smtp-Source: ABdhPJxBw/7k/+JRETNKBB42v8v1GfG6J3sjMbXTROsk6jtNiyv9PoMPIxzh5F3nxmtmVsOdGHSA5w== X-Received: by 2002:a5d:69cf:: with SMTP id s15mr18865664wrw.372.1610825658407; Sat, 16 Jan 2021 11:34:18 -0800 (PST) Received: from [192.168.8.126] ([85.255.234.150]) by smtp.gmail.com with ESMTPSA id z6sm16146266wmi.15.2021.01.16.11.34.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 16 Jan 2021 11:34:17 -0800 (PST) Subject: Re: Fixed buffers have out-dated content To: Martin Raiber , Jens Axboe , io-uring@vger.kernel.org References: <01020176e45e6c4d-c15dc1e2-6a6a-407c-a32d-24be51a1b3f8-000000@eu-west-1.amazonses.com> <8ba549a0-7724-a42f-bd11-3605ef0bd034@kernel.dk> <01020176e8159fa5-3f556133-fda7-451b-af78-94c712df611e-000000@eu-west-1.amazonses.com> <01020176ed350725-cc3c8fa7-7771-46c9-8fa9-af433acb2453-000000@eu-west-1.amazonses.com> <0102017702e086ca-cdb34993-86ad-4ec6-bea5-b6a5ad055a62-000000@eu-west-1.amazonses.com> From: Pavel Begunkov Autocrypt: addr=asml.silence@gmail.com; prefer-encrypt=mutual; keydata= mQINBFmKBOQBEAC76ZFxLAKpDw0bKQ8CEiYJRGn8MHTUhURL02/7n1t0HkKQx2K1fCXClbps bdwSHrhOWdW61pmfMbDYbTj6ZvGRvhoLWfGkzujB2wjNcbNTXIoOzJEGISHaPf6E2IQx1ik9 6uqVkK1OMb7qRvKH0i7HYP4WJzYbEWVyLiAxUj611mC9tgd73oqZ2pLYzGTqF2j6a/obaqha +hXuWTvpDQXqcOZJXIW43atprH03G1tQs7VwR21Q1eq6Yvy2ESLdc38EqCszBfQRMmKy+cfp W3U9Mb1w0L680pXrONcnlDBCN7/sghGeMHjGKfNANjPc+0hzz3rApPxpoE7HC1uRiwC4et83 CKnncH1l7zgeBT9Oa3qEiBlaa1ZCBqrA4dY+z5fWJYjMpwI1SNp37RtF8fKXbKQg+JuUjAa9 Y6oXeyEvDHMyJYMcinl6xCqCBAXPHnHmawkMMgjr3BBRzODmMr+CPVvnYe7BFYfoajzqzq+h EyXSl3aBf0IDPTqSUrhbmjj5OEOYgRW5p+mdYtY1cXeK8copmd+fd/eTkghok5li58AojCba jRjp7zVOLOjDlpxxiKhuFmpV4yWNh5JJaTbwCRSd04sCcDNlJj+TehTr+o1QiORzc2t+N5iJ NbILft19Izdn8U39T5oWiynqa1qCLgbuFtnYx1HlUq/HvAm+kwARAQABtDFQYXZlbCBCZWd1 bmtvdiAoc2lsZW5jZSkgPGFzbWwuc2lsZW5jZUBnbWFpbC5jb20+iQJOBBMBCAA4FiEE+6Ju PTjTbx479o3OWt5b1Glr+6UFAlmKBOQCGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQ Wt5b1Glr+6WxZA//QueaKHzgdnOikJ7NA/Vq8FmhRlwgtP0+E+w93kL+ZGLzS/cUCIjn2f4Q Mcutj2Neg0CcYPX3b2nJiKr5Vn0rjJ/suiaOa1h1KzyNTOmxnsqE5fmxOf6C6x+NKE18I5Jy xzLQoktbdDVA7JfB1itt6iWSNoOTVcvFyvfe5ggy6FSCcP+m1RlR58XxVLH+qlAvxxOeEr/e aQfUzrs7gqdSd9zQGEZo0jtuBiB7k98t9y0oC9Jz0PJdvaj1NZUgtXG9pEtww3LdeXP/TkFl HBSxVflzeoFaj4UAuy8+uve7ya/ECNCc8kk0VYaEjoVrzJcYdKP583iRhOLlZA6HEmn/+Gh9 4orG67HNiJlbFiW3whxGizWsrtFNLsSP1YrEReYk9j1SoUHHzsu+ZtNfKuHIhK0sU07G1OPN 2rDLlzUWR9Jc22INAkhVHOogOcc5ajMGhgWcBJMLCoi219HlX69LIDu3Y34uIg9QPZIC2jwr 24W0kxmK6avJr7+n4o8m6sOJvhlumSp5TSNhRiKvAHB1I2JB8Q1yZCIPzx+w1ALxuoWiCdwV M/azguU42R17IuBzK0S3hPjXpEi2sK/k4pEPnHVUv9Cu09HCNnd6BRfFGjo8M9kZvw360gC1 reeMdqGjwQ68o9x0R7NBRrtUOh48TDLXCANAg97wjPoy37dQE7e5Ag0EWYoE5AEQAMWS+aBV IJtCjwtfCOV98NamFpDEjBMrCAfLm7wZlmXy5I6o7nzzCxEw06P2rhzp1hIqkaab1kHySU7g dkpjmQ7Jjlrf6KdMP87mC/Hx4+zgVCkTQCKkIxNE76Ff3O9uTvkWCspSh9J0qPYyCaVta2D1 Sq5HZ8WFcap71iVO1f2/FEHKJNz/YTSOS/W7dxJdXl2eoj3gYX2UZNfoaVv8OXKaWslZlgqN jSg9wsTv1K73AnQKt4fFhscN9YFxhtgD/SQuOldE5Ws4UlJoaFX/yCoJL3ky2kC0WFngzwRF Yo6u/KON/o28yyP+alYRMBrN0Dm60FuVSIFafSqXoJTIjSZ6olbEoT0u17Rag8BxnxryMrgR dkccq272MaSS0eOC9K2rtvxzddohRFPcy/8bkX+t2iukTDz75KSTKO+chce62Xxdg62dpkZX xK+HeDCZ7gRNZvAbDETr6XI63hPKi891GeZqvqQVYR8e+V2725w+H1iv3THiB1tx4L2bXZDI DtMKQ5D2RvCHNdPNcZeldEoJwKoA60yg6tuUquvsLvfCwtrmVI2rL2djYxRfGNmFMrUDN1Xq F3xozA91q3iZd9OYi9G+M/OA01husBdcIzj1hu0aL+MGg4Gqk6XwjoSxVd4YT41kTU7Kk+/I 5/Nf+i88ULt6HanBYcY/+Daeo/XFABEBAAGJAjYEGAEIACAWIQT7om49ONNvHjv2jc5a3lvU aWv7pQUCWYoE5AIbDAAKCRBa3lvUaWv7pfmcEACKTRQ28b1y5ztKuLdLr79+T+LwZKHjX++P 4wKjEOECCcB6KCv3hP+J2GCXDOPZvdg/ZYZafqP68Yy8AZqkfa4qPYHmIdpODtRzZSL48kM8 LRzV8Rl7J3ItvzdBRxf4T/Zseu5U6ELiQdCUkPGsJcPIJkgPjO2ROG/ZtYa9DvnShNWPlp+R uPwPccEQPWO/NP4fJl2zwC6byjljZhW5kxYswGMLBwb5cDUZAisIukyAa8Xshdan6C2RZcNs rB3L7vsg/R8UCehxOH0C+NypG2GqjVejNZsc7bgV49EOVltS+GmGyY+moIzxsuLmT93rqyII 5rSbbcTLe6KBYcs24XEoo49Zm9oDA3jYvNpeYD8rDcnNbuZh9kTgBwFN41JHOPv0W2FEEWqe JsCwQdcOQ56rtezdCJUYmRAt3BsfjN3Jn3N6rpodi4Dkdli8HylM5iq4ooeb5VkQ7UZxbCWt UVMKkOCdFhutRmYp0mbv2e87IK4erwNHQRkHUkzbsuym8RVpAZbLzLPIYK/J3RTErL6Z99N2 m3J6pjwSJY/zNwuFPs9zGEnRO4g0BUbwGdbuvDzaq6/3OJLKohr5eLXNU3JkT+3HezydWm3W OPhauth7W0db74Qd49HXK0xe/aPrK+Cp+kU1HRactyNtF8jZQbhMCC8vMGukZtWaAwpjWiiH bA== Message-ID: <25f75e49-9d5e-fcab-e24b-8ad908254c2e@gmail.com> Date: Sat, 16 Jan 2021 19:30:42 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <0102017702e086ca-cdb34993-86ad-4ec6-bea5-b6a5ad055a62-000000@eu-west-1.amazonses.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 14/01/2021 21:50, Martin Raiber wrote: > On 10.01.2021 17:50 Martin Raiber wrote: >> On 09.01.2021 21:32 Pavel Begunkov wrote: >>> On 09/01/2021 16:58, Martin Raiber wrote: >>>> On 09.01.2021 17:23 Jens Axboe wrote: >>>>> On 1/8/21 4:39 PM, Martin Raiber wrote: >>>>>> Hi, >>>>>> >>>>>> I have a gnarly issue with io_uring and fixed buffers (fixed >>>>>> read/write). It seems the contents of those buffers contain old data in >>>>>> some rare cases under memory pressure after a read/during a write. >>>>>> >>>>>> Specifically I use io_uring with fuse and to confirm this is not some >>>>>> user space issue let fuse print the unique id it adds to each request. >>>>>> Fuse adds this request data to a pipe, and when the pipe buffer is later >>>>>> copied to the io_uring fixed buffer it has the id of a fuse request >>>>>> returned earlier using the same buffer while returning the size of the >>>>>> new request. Or I set the unique id in the buffer, write it to fuse (via >>>>>> writing to a pipe, then splicing) and then fuse returns with e.g. >>>>>> ENOENT, because the unique id is not correct because in kernel it reads >>>>>> the id of the previous, already completed, request using this buffer. >>>>>> >>>>>> To make reproducing this faster running memtester (which mlocks a >>>>>> configurable amount of memory) with a large amount of user memory every >>>>>> 30s helps. So it has something to do with swapping? It seems to not >>>>>> occur if no swap space is active. Problem occurs without warning when >>>>>> the kernel is build with KASAN and slab debugging. >>>>>> >>>>>> If I don't use the _FIXED opcodes (which is easy to do), the problem >>>>>> does not occur. >>>>>> >>>>>> Problem occurs with 5.9.16 and 5.10.5. >>>>> Can you mention more about what kind of IO you are doing, I'm assuming >>>>> it's O_DIRECT? I'll see if I can reproduce this. >>>> It's writing to/reading from pipes (nonblocking, no O_DIRECT). >>> A blind guess, does it handle short reads and writes? If not, can you >>> check whether they happen or not? >> >> Something like this was what I suspected at first as well. It does check for short read/writes and I added (unnecessary -- because the fuse request structure is 40 bytes and it does io in page sizes) code for retrying short reads at some point. I also checked for the pipes to be empty before they are used at some point and let the kernel log allocation failures (idea was that it was short pipe read/writes because of allocation failure or that something doesn't get rewound properly in this case). Beyond that three things that make a user space problem unlikely: >> >>  - occurs only when using fixed buffers and does not occur when running same code without fixed buffer opcodes >>  - doesn't occur when there is no memory pressure >>  - I added print(k/f) logging that pointed me in this direction as well >> >>>> I can reproduce it with https://github.com/uroni/fuseuring on e.g. a 2GB VPS. Modify bench.sh so that fio loops. Add swap, then run 1400M memtester while it runs (so it swaps, I guess). I can try further reducing the reproducer, but I wanted to avoid that work in case it is something obvious. The next step would be to remove fuse from the equation -- it does try to move the pages from the pipe when splicing to it, for example. > > When I use 5.10.7 with 09854ba94c6aad7886996bfbee2530b3d8a7f4f4 ("mm: do_wp_page() simplification"), 1a0cf26323c80e2f1c58fc04f15686de61bfab0c ("mm/ksm: Remove reuse_ksm_page()") and be068f29034fb00530a053d18b8cf140c32b12b3 ("mm: fix misplaced unlock_page in do_wp_page()") reverted the issue doesn't seem to occur. Thanks for tracking it down. Was it reported to Linus and Peter? -- Pavel Begunkov