From: Chaitanya Kulkarni <[email protected]>
To: Kanchan Joshi <[email protected]>,
"[email protected]" <[email protected]>, "[email protected]" <[email protected]>,
"[email protected]" <[email protected]>
Cc: "[email protected]" <[email protected]>,
"[email protected]" <[email protected]>,
"[email protected]" <[email protected]>
Subject: Re: [PATCH for-next v5 4/4] nvme: wire up fixed buffer support for nvme passthrough
Date: Wed, 7 Sep 2022 14:51:31 +0000 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
> req = nvme_alloc_user_request(q, cmd, ubuffer, bufflen, meta_buffer,
> - meta_len, meta_seed, &meta, timeout, vec, 0, 0);
> + meta_len, meta_seed, &meta, timeout, vec, 0, 0, NULL, 0);
> if (IS_ERR(req))
> return PTR_ERR(req);
14 Arguments to the function!
Kanchan, I'm not pointing out to this patch it has happened over
the years, I think it is high time we find a way to trim this
down.
Least we can do is to pass a structure member than 14 different
arguments, is everyone okay with it ?
-ck
next prev parent reply other threads:[~2022-09-07 14:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220906063719epcas5p3157e79583a5412a3be81f3d96f8aaadd@epcas5p3.samsung.com>
2022-09-06 6:27 ` [PATCH for-next v5 0/4] fixed-buffer for uring-cmd/passthru Kanchan Joshi
[not found] ` <CGME20220906063723epcas5p23946fd33031aee591210af1c3cd2d574@epcas5p2.samsung.com>
2022-09-06 6:27 ` [PATCH for-next v5 1/4] io_uring: introduce io_uring_cmd_import_fixed Kanchan Joshi
[not found] ` <CGME20220906063726epcas5p42f764b4c01b841dd1fc34abebcab02e6@epcas5p4.samsung.com>
2022-09-06 6:27 ` [PATCH for-next v5 2/4] io_uring: introduce fixed buffer support for io_uring_cmd Kanchan Joshi
[not found] ` <CGME20220906063729epcas5p1bf05e6873de0f7246234380d66c21fb9@epcas5p1.samsung.com>
2022-09-06 6:27 ` [PATCH for-next v5 3/4] block: add helper to map bvec iterator for passthrough Kanchan Joshi
2022-09-07 15:32 ` Chaitanya Kulkarni
2022-09-08 10:52 ` Kanchan Joshi
2022-09-08 14:46 ` Jens Axboe
2022-09-08 15:11 ` Pankaj Raghav
[not found] ` <CGME20220906063733epcas5p22984174bd6dbb2571152fea18af90924@epcas5p2.samsung.com>
2022-09-06 6:27 ` [PATCH for-next v5 4/4] nvme: wire up fixed buffer support for nvme passthrough Kanchan Joshi
2022-09-07 14:51 ` Chaitanya Kulkarni [this message]
2022-09-08 10:47 ` Kanchan Joshi
2022-09-08 14:50 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox