Re: [PATCH 5.19] io_uring: move io_uring_get_opcode out of TP_printk

[Dylan Yudaken <dylany@fb.com>]

On Thu, 2022-06-23 at 08:36 -0600, Jens Axboe wrote:
> On 6/23/22 2:37 AM, Dylan Yudaken wrote:
> > @@ -390,6 +402,8 @@ TRACE_EVENT(io_uring_submit_sqe,
> >                 __field(  u32,                  flags           )
> >                 __field(  bool,                 force_nonblock  )
> >                 __field(  bool,                 sq_thread       )
> > +
> > +               __string( op_str, io_uring_get_opcode(opcode) )
> >         ),
> >  
> >         TP_fast_assign(
> > @@ -399,12 +413,13 @@ TRACE_EVENT(io_uring_submit_sqe,
> >                 __entry->opcode         = opcode;
> >                 __entry->flags          = flags;
> >                 __entry->force_nonblock = force_nonblock;
> > -               __entry->sq_thread      = sq_thread;
> > +
> > +               __assign_str(op_str, io_uring_get_opcode(opcode));
> >         ),
> >  
> 
> Looks like a spurious removal here of the sq_thread assignment? I
> will
> fix it up.
> 

Ah damn. Good spot!

Thanks!