public inbox for io-uring@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Keith Busch <kbusch@kernel.org>, veygax <veyga@veygax.dev>
Cc: Ming Lei <ming.lei@redhat.com>,
	"io-uring@vger.kernel.org" <io-uring@vger.kernel.org>,
	Caleb Sander Mateos <csander@purestorage.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] io_uring/rsrc: fix slab-out-of-bounds in io_buffer_register_bvec
Date: Thu, 18 Dec 2025 20:28:30 -0700	[thread overview]
Message-ID: <2805e3cf-becb-4bcf-bf5e-96d3820f437b@kernel.dk> (raw)
In-Reply-To: <aUSHcH9TccvzgQkG@kbusch-mbp>

On 12/18/25 4:00 PM, Keith Busch wrote:
> On Thu, Dec 18, 2025 at 01:13:11AM +0000, veygax wrote:
>> On 18/12/2025 00:56, Keith Busch wrote:
>>> I believe you're supposed to use the bio_add_page() API rather than open
>>> code the bvec setup.
>>
>> True, but I wanted fine control to prove my theory
> 
> But doesn't that just prove misusing the interface breaks things? Is
> there currently a legit way to get this error without the misuse? Or is
> there existing mis-use in the kernel that should be fixed instead?

This is the big question, and also why I originally rejected the posted
poc as it's not a valid use case.

veygax, please make a real reproducer or detail how this can actually
happen with the exposed APIs.

-- 
Jens Axboe


  reply	other threads:[~2025-12-19  3:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-17 21:04 [PATCH] io_uring/rsrc: fix slab-out-of-bounds in io_buffer_register_bvec veygax
2025-12-17 21:22 ` Caleb Sander Mateos
2025-12-18  0:32 ` Ming Lei
2025-12-18  0:37   ` veygax
2025-12-18  0:56     ` Keith Busch
2025-12-18  1:13       ` veygax
2025-12-18  2:58         ` Ming Lei
2025-12-18 23:00         ` Keith Busch
2025-12-19  3:28           ` Jens Axboe [this message]
2025-12-19  5:33       ` Christoph Hellwig
2025-12-21 23:29         ` Keith Busch
2025-12-22 22:08           ` Christoph Hellwig
2025-12-22  1:02         ` veygax

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2805e3cf-becb-4bcf-bf5e-96d3820f437b@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=csander@purestorage.com \
    --cc=io-uring@vger.kernel.org \
    --cc=kbusch@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=veyga@veygax.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox