public inbox for [email protected]
 help / color / mirror / Atom feed
From: Jens Axboe <[email protected]>
To: Dmitry Shulyak <[email protected]>
Cc: [email protected]
Subject: Re: Large number of empty reads on 5.9-rc2 under moderate load
Date: Mon, 24 Aug 2020 10:10:02 -0600	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAF-ewDrMO-qGOfXdZUyaGBzH+yY3EBPHCO_bMvj6yXhZeCFaEw@mail.gmail.com>

On 8/24/20 9:33 AM, Dmitry Shulyak wrote:
> On Mon, 24 Aug 2020 at 17:45, Jens Axboe <[email protected]> wrote:
>>
>> On 8/24/20 8:06 AM, Jens Axboe wrote:
>>> On 8/24/20 5:09 AM, Dmitry Shulyak wrote:
>>>> library that i am using https://github.com/dshulyak/uring
>>>> It requires golang 1.14, if installed, benchmark can be run with:
>>>> go test ./fs -run=xx -bench=BenchmarkReadAt/uring_8 -benchtime=1000000x
>>>> go test ./fs -run=xx -bench=BenchmarkReadAt/uring_5 -benchtime=8000000x
>>>>
>>>> note that it will setup uring instance per cpu, with shared worker pool.
>>>> it will take me too much time to implement repro in c, but in general
>>>> i am simply submitting multiple concurrent
>>>> read requests and watching read rate.
>>>
>>> I'm fine with trying your Go version, but I can into a bit of trouble:
>>>
>>> axboe@amd ~/g/go-uring (master)>
>>> go test ./fs -run=xx -bench=BenchmarkReadAt/uring_8 -benchtime=1000000x
>>> # github.com/dshulyak/uring/fixed
>>> fixed/allocator.go:38:48: error: incompatible type for field 2 in struct construction (cannot use type uint64 as type syscall.Iovec_len_t)
>>>    38 |  iovec := []syscall.Iovec{{Base: &mem[0], Len: uint64(size)}}
>>>       |                                                ^
>>> FAIL  github.com/dshulyak/uring/fs [build failed]
>>> FAIL
>>> axboe@amd ~/g/go-uring (master)> go version
>>> go version go1.14.6 gccgo (Ubuntu 10.2.0-5ubuntu1~20.04) 10.2.0 linux/amd64
>>
>> Alright, got it working. What device are you running this on? And am I
>> correct in assuming you get short reads, or rather 0 reads? What file
>> system?
>
> Was going to look into this.
> I am getting 0 reads. This is on some old kingston ssd, ext4.

I can't seem to reproduce this. I do see some cqe->res == 0 completes,
but those appear to be NOPs. And they trigger at the start and end. I'll
keep poking.

-- 
Jens Axboe


  reply	other threads:[~2020-08-24 16:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-24 10:40 Large number of empty reads on 5.9-rc2 under moderate load Dmitry Shulyak
2020-08-24 10:46 ` Jens Axboe
2020-08-24 11:09   ` Dmitry Shulyak
2020-08-24 14:06     ` Jens Axboe
2020-08-24 14:45       ` Jens Axboe
2020-08-24 15:33         ` Dmitry Shulyak
2020-08-24 16:10           ` Jens Axboe [this message]
2020-08-24 16:13             ` Dmitry Shulyak
2020-08-24 16:18               ` Jens Axboe
2020-08-24 17:44                 ` Jens Axboe
2020-08-25  8:52                   ` Dmitry Shulyak
2020-08-25 13:39                     ` Jens Axboe
2020-08-25 14:14                       ` Dmitry Shulyak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox