From: Jens Axboe <[email protected]>
To: Stefan Metzmacher <[email protected]>, [email protected]
Subject: Re: [PATCH] io_uring: add BUILD_BUG_ON() to assert the layout of struct io_uring_sqe
Date: Thu, 30 Jan 2020 08:51:48 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 1/29/20 6:39 AM, Stefan Metzmacher wrote:
> With nesting of anonymous unions and structs it's hard to
> review layout changes. It's better to ask the compiler
> for these things.
I don't think I've once messed it up while adding new features,
but I'm fine with adding this as an extra safeguard. Realistically,
the regression tests would fail spectacularly if we ever did mess
this up.
--
Jens Axboe
next prev parent reply other threads:[~2020-01-30 15:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 13:22 [PATCH] io_uring: add BUILD_BUG_ON() to assert the layout of struct io_uring_sqe Stefan Metzmacher
2020-01-29 13:39 ` Stefan Metzmacher
2020-01-30 15:51 ` Jens Axboe [this message]
2020-01-30 16:01 ` Stefan Metzmacher
2020-01-30 16:06 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox