From: Jens Axboe <axboe@kernel.dk>
To: Caleb Sander Mateos <csander@purestorage.com>
Cc: io-uring@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] io_uring: remove WRITE_ONCE() in io_uring_create()
Date: Tue, 2 Sep 2025 19:20:55 -0600 [thread overview]
Message-ID: <28b5e071-70f2-4f46-86af-11879be0f2a4@kernel.dk> (raw)
In-Reply-To: <20250902215144.1925256-1-csander@purestorage.com>
On 9/2/25 3:51 PM, Caleb Sander Mateos wrote:
> There's no need to use WRITE_ONCE() to set ctx->submitter_task in
> io_uring_create() since no other thread can access the io_ring_ctx until
> a file descriptor is associated with it. So use a normal assignment
> instead of WRITE_ONCE().
Would probably warrant a code comment to that effect, as just reading
the code would be slightly confusing after this.
--
Jens Axboe
next prev parent reply other threads:[~2025-09-03 1:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-02 21:51 [PATCH] io_uring: remove WRITE_ONCE() in io_uring_create() Caleb Sander Mateos
2025-09-03 1:20 ` Jens Axboe [this message]
2025-09-03 3:32 ` Caleb Sander Mateos
2025-09-03 23:16 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28b5e071-70f2-4f46-86af-11879be0f2a4@kernel.dk \
--to=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox