* [PATCH liburing 1/1] test/io-cancel: expand print messages
@ 2024-07-24 11:10 Pavel Begunkov
2024-07-24 13:58 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Pavel Begunkov @ 2024-07-24 11:10 UTC (permalink / raw)
To: io-uring; +Cc: Jens Axboe, asml.silence
Add at least some explanation on what it's printing.
Signed-off-by: Pavel Begunkov <[email protected]>
---
test/io-cancel.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/test/io-cancel.c b/test/io-cancel.c
index 8dca2c3..adf31e7 100644
--- a/test/io-cancel.c
+++ b/test/io-cancel.c
@@ -347,18 +347,21 @@ static int test_cancel_req_across_fork(void)
case 1:
if (cqe->res != -EINTR &&
cqe->res != -ECANCELED) {
- fprintf(stderr, "%i %i\n", (int)cqe->user_data, cqe->res);
+ fprintf(stderr, "user_data %i res %i\n",
+ (unsigned)cqe->user_data, cqe->res);
exit(1);
}
break;
case 2:
if (cqe->res != -EALREADY && cqe->res) {
- fprintf(stderr, "%i %i\n", (int)cqe->user_data, cqe->res);
+ fprintf(stderr, "user_data %i res %i\n",
+ (unsigned)cqe->user_data, cqe->res);
exit(1);
}
break;
default:
- fprintf(stderr, "%i %i\n", (int)cqe->user_data, cqe->res);
+ fprintf(stderr, "user_data %i res %i\n",
+ (unsigned)cqe->user_data, cqe->res);
exit(1);
}
@@ -451,7 +454,8 @@ static int test_cancel_inflight_exit(void)
if ((cqe->user_data == 1 && cqe->res != -ECANCELED) ||
(cqe->user_data == 2 && cqe->res != -ECANCELED) ||
(cqe->user_data == 3 && cqe->res != -ETIME)) {
- fprintf(stderr, "%i %i\n", (int)cqe->user_data, cqe->res);
+ fprintf(stderr, "user_data %i res %i\n",
+ (unsigned)cqe->user_data, cqe->res);
return 1;
}
io_uring_cqe_seen(&ring, cqe);
--
2.44.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH liburing 1/1] test/io-cancel: expand print messages
2024-07-24 11:10 [PATCH liburing 1/1] test/io-cancel: expand print messages Pavel Begunkov
@ 2024-07-24 13:58 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2024-07-24 13:58 UTC (permalink / raw)
To: io-uring, Pavel Begunkov
On Wed, 24 Jul 2024 12:10:35 +0100, Pavel Begunkov wrote:
> Add at least some explanation on what it's printing.
>
>
Applied, thanks!
[1/1] test/io-cancel: expand print messages
commit: 6bf99f89d07f818101cc9305cb40c8c53d828a88
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-24 13:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-24 11:10 [PATCH liburing 1/1] test/io-cancel: expand print messages Pavel Begunkov
2024-07-24 13:58 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox