Re: [PATCH liburing] Delete `src/syscall.c` and get back to use `__sys_io_uring*` functions

[Jens Axboe <axboe@kernel.dk>]

On 7/21/22 9:35 AM, Ammar Faizi wrote:
> On 7/21/22 10:32 PM, Jens Axboe wrote:
>> On Thu, 21 Jul 2022 16:04:43 +0700, Ammar Faizi wrote:
>>> Back when I was adding nolibc support for liburing, I added new
>>> wrapper functions for io_uring system calls. They are ____sys_io_uring*
>>> functions (with 4 underscores), all defined as an inline function.
>>>
>>> I left __sys_uring* functions (with 2 underscores) live in syscall.c
>>> because I thought it might break the user if we delete them. But it
>>> turned out that I was wrong, no user should use these functions
>>> because we don't export them. This situation is reflected in
>>> liburing.map and liburing.h which don't have those functions.
>>>
>>> [...]
>>
>> Applied, thanks!
>>
>> [1/1] Delete `src/syscall.c` and get back to use `__sys_io_uring*` functions
>>        commit: 4aa1a8aefc3dc3875621c64cef0087968e57181d
> 
> Sorry Jens, it breaks other architectures, will send a patch shortly.

I ran x86-64 and aarch64, seems that it did indeed break x86. I'll wait
for your patch.

-- 
Jens Axboe