public inbox for [email protected]
 help / color / mirror / Atom feed
From: Jens Axboe <[email protected]>
To: Ammar Faizi <[email protected]>
Cc: Hao Xu <[email protected]>,
	Pavel Begunkov <[email protected]>,
	Fernanda Ma'rouf <[email protected]>,
	GNU/Weeb Mailing List <[email protected]>,
	io-uring Mailing List <[email protected]>
Subject: Re: [PATCH liburing] Delete `src/syscall.c` and get back to use `__sys_io_uring*` functions
Date: Thu, 21 Jul 2022 09:36:34 -0600	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 7/21/22 9:35 AM, Ammar Faizi wrote:
> On 7/21/22 10:32 PM, Jens Axboe wrote:
>> On Thu, 21 Jul 2022 16:04:43 +0700, Ammar Faizi wrote:
>>> Back when I was adding nolibc support for liburing, I added new
>>> wrapper functions for io_uring system calls. They are ____sys_io_uring*
>>> functions (with 4 underscores), all defined as an inline function.
>>>
>>> I left __sys_uring* functions (with 2 underscores) live in syscall.c
>>> because I thought it might break the user if we delete them. But it
>>> turned out that I was wrong, no user should use these functions
>>> because we don't export them. This situation is reflected in
>>> liburing.map and liburing.h which don't have those functions.
>>>
>>> [...]
>>
>> Applied, thanks!
>>
>> [1/1] Delete `src/syscall.c` and get back to use `__sys_io_uring*` functions
>>        commit: 4aa1a8aefc3dc3875621c64cef0087968e57181d
> 
> Sorry Jens, it breaks other architectures, will send a patch shortly.

I ran x86-64 and aarch64, seems that it did indeed break x86. I'll wait
for your patch.

-- 
Jens Axboe


  reply	other threads:[~2022-07-21 15:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-21  9:04 [PATCH liburing] Delete `src/syscall.c` and get back to use `__sys_io_uring*` functions Ammar Faizi
2022-07-21 15:32 ` Jens Axboe
2022-07-21 15:35   ` Ammar Faizi
2022-07-21 15:36     ` Jens Axboe [this message]
2022-07-21 15:51       ` [PATCH] arch/generic: Rename `____sys_io_uring*` to `__sys_io_uring*` Ammar Faizi
2022-07-21 15:59         ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox