From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E7AD1AED24 for ; Wed, 11 Sep 2024 16:28:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726072099; cv=none; b=g/9JeKJkOxW4V9Q3gCf+gJNs076TYsrv4GPbnjl7zmLdjlWLItftBxhCyQw1w5KTXGS1ekfl0s1kZqzouZqOtlUTbotElH3vgtEyOd92RG6nGMkIVlcPm6xL1jjwOIuDMi6YWfPkqlKBxoXvb1OKjldFt+7oG3Y/zh1+GRTwJ2Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726072099; c=relaxed/simple; bh=tzTpPj6JB+OGJA5fajUvUDBqkigFVyaXVi86a5AhPe8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JZQiyfD2HVh43s1FcNwpUaTHRpwdPdABB7zvY9Sy1aCK72WrTtpPD2Sy7PTblIgEUSFDmWzz/26t1dl5xCcKwBsrdKvN0SQmxTM7PAmFKOcEFNwr8L8jtYgh60RmUz93hP/pJZnJuci2/5hai+mk7Qv+pFDqh9pkqBApxzo8iAA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=w/27mDo8; arc=none smtp.client-ip=209.85.166.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="w/27mDo8" Received: by mail-io1-f47.google.com with SMTP id ca18e2360f4ac-82ade877fbeso220862839f.0 for ; Wed, 11 Sep 2024 09:28:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1726072097; x=1726676897; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=var502O8AdEcPofnm3n0MJMBP1NCf8qy9e9DtiMVmWk=; b=w/27mDo8Tjyr7ktZ/rxJSgyRxb7SH4BZvtnkXmFXPJDmLowh2LTb2NvySGSVjIa4mE aOzyDFZtPY2MM1mfUUkV+q3Pshr7bwyQCs0g3yMjl2aYjdI3UHwpKNghR/jFGxasMlm8 fsZNcZaHe24gCTWYuEf4Xt8TsgVACtxT8xdKd6O8HL/0gC07R5DWBPOGQJLQBJ1q0877 0OvU9sw5JuMpbthCB1B9nE25yrKNBQtF8fFFstO5uMku2eIgLUHNFc8dEQ4d3Ic86aSh zyB47aIRFanV+2+Wja2MOdAgybpjlKC7QdFAL8asYDpqI2X2JDv+bTInmKZPrU1W4XT2 5M1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726072097; x=1726676897; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=var502O8AdEcPofnm3n0MJMBP1NCf8qy9e9DtiMVmWk=; b=GAXHZ+2R8IQOJ1MK2cRGLEN+H/4vq40Mj16hQ6yg+ecf21+RAF7ibnrlg9ehOLpFC2 +N6wltwa1ccDYGvtYqxzZLOuxAJFanem7HD8pnlLp6i8asSeP21klxeT2Vnov6iiJ4V0 nKggRP0T9x5Qd9q8XL1axW4sHwzMqy2bDom959Ku/cwQavOGi11dGjYwfUC7zOrqNAP0 q9U95luBN4K3LReHDuT7L+zuj+beO9EBxywMe+YwTt4s8N4krV2ejRqkOoNUND8NMWYO 5joww405Dr5RsB7u7n/rNGQ3/4kAqCUOIijOxV6BQEIR2fBcLb47TW1zehPDLvBx7i6+ eLNw== X-Forwarded-Encrypted: i=1; AJvYcCVrNkaQXzVn/E2J+GhaWef3YvImkE8n4dEMrlYJppDJfyw+QLh6e4njrKCXehrXLZ0c4JK+wTd/rA==@vger.kernel.org X-Gm-Message-State: AOJu0Yzx2A2OrRX3QgWO5vwQiRcA1C9WDvmRVlczrIr0liW2kwQN9Tfj Hk/dexweOVH34QdtibogjW4/HRs6rZmznEAY1nk0V1g4Qv9CMQ1u96aLmN6NtWw= X-Google-Smtp-Source: AGHT+IEOAHWAK6/GldVHC+a73yGd6kwIS+31Iy8D7c2tKpxIayyx3VhAXsleXj/4G1VFA/tiJKjY6w== X-Received: by 2002:a05:6602:2b11:b0:82a:971d:b4a0 with SMTP id ca18e2360f4ac-82d1f978fd6mr21465139f.13.1726072095997; Wed, 11 Sep 2024 09:28:15 -0700 (PDT) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-82aa77b292bsm276246139f.47.2024.09.11.09.28.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Sep 2024 09:28:15 -0700 (PDT) Message-ID: <2a424df7-8114-477e-ab5c-484d2ed8d9a4@kernel.dk> Date: Wed, 11 Sep 2024 10:28:14 -0600 Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6.1 0/2] io_uring/io-wq: respect cgroup cpusets To: Felix Moessbauer Cc: stable@vger.kernel.org, asml.silence@gmail.com, linux-kernel@vger.kernel.org, io-uring@vger.kernel.org, cgroups@vger.kernel.org, dqminh@cloudflare.com, longman@redhat.com, adriaan.schmidt@siemens.com, florian.bezdeka@siemens.com References: <20240911162316.516725-1-felix.moessbauer@siemens.com> Content-Language: en-US From: Jens Axboe In-Reply-To: <20240911162316.516725-1-felix.moessbauer@siemens.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 9/11/24 10:23 AM, Felix Moessbauer wrote: > Hi, > > as discussed in [1], this is a manual backport of the remaining two > patches to let the io worker threads respect the affinites defined by > the cgroup of the process. > > In 6.1 one worker is created per NUMA node, while in da64d6db3bd3 > ("io_uring: One wqe per wq") this is changed to only have a single worker. > As this patch is pretty invasive, Jens and me agreed to not backport it. > > Instead we now limit the workers cpuset to the cpus that are in the > intersection between what the cgroup allows and what the NUMA node has. > This leaves the question what to do in case the intersection is empty: > To be backwarts compatible, we allow this case, but restrict the cpumask > of the poller to the cpuset defined by the cgroup. We further believe > this is a reasonable decision, as da64d6db3bd3 drops the NUMA awareness > anyways. > > [1] https://lore.kernel.org/lkml/ec01745a-b102-4f6e-abc9-abd636d36319@kernel.dk The upstream patches are staged for 6.12 and marked for a backport, so they should go upstream next week. Once they are upstream, I'll make sure to check in on these on the stable front. -- Jens Axboe