From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EC72C433DB for ; Thu, 25 Mar 2021 13:39:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7C4D261A1F for ; Thu, 25 Mar 2021 13:39:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230296AbhCYNjX (ORCPT ); Thu, 25 Mar 2021 09:39:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230134AbhCYNiv (ORCPT ); Thu, 25 Mar 2021 09:38:51 -0400 Received: from mail-io1-xd2c.google.com (mail-io1-xd2c.google.com [IPv6:2607:f8b0:4864:20::d2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16DC3C061760 for ; Thu, 25 Mar 2021 06:38:51 -0700 (PDT) Received: by mail-io1-xd2c.google.com with SMTP id n21so1936400ioa.7 for ; Thu, 25 Mar 2021 06:38:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=eM1i1Yk87DzUyuufIUGNIKd4zH4tVzCeadWKa9Xb/JU=; b=XdHRtgYk0+DLpDrv3ToQu5LWl0EYWRXpd/TbmPrRxtPCCkTI1FtzSRyh+dBxxClmvL +q9RzafC27umFrgzVkXSOeHFGrfjKrrqJTm7RqEDtLXp7PwkuxLlD46X/G1Tssmszq6G H3bjL9t24Wj3tcTTmVqNoHu/QwKYDo76LNFmaag0zJ9hhsFJ0dJ4VNFm70qp+KBVcXpJ M1thxus4OrUpRTyMkoXMORYOiKpO+fQx3AnD0lUgQ0Wih12kQpF+7omp4c3lv1Uihm8i n94wWdDv7paeA6/5WbaZxsn/dwpQScoYDCcQKuTXN4/s52NloR4Al9i92lhhyd0lTdCF GfTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=eM1i1Yk87DzUyuufIUGNIKd4zH4tVzCeadWKa9Xb/JU=; b=V2alIscPdpuGLTuac0kgmZ64t5m92J+NG57btOcBofRK5W4mqyLWFH4oyULi/nAUzy +RXokFqtjqgPXp9I+bfVeP10zNJnNwKPvyYq6vULBhO4OuXMeDq1iQxSGVxXjSISW77I XDmOEfAtohBdrBu8McWl1q0D5oRJnLCm7Z6vNhj293F5zcjkbUS88dMKNtWpq8QcwiNZ dPpolgHkGj6QyjQiJiK2iFL3q1MYBTFRufGCP2qNiXq0sOWlAZJUpaXtC0vIc5lGIGQo 9Hk3LhyCMKPpB1ZZC1cd/3WMas1ZezvZjOBwSPmScl+ru4d4QI+ckhQ9X0CotY4bFts4 0ykQ== X-Gm-Message-State: AOAM530qF3Cpu0H2+EfKP4OS+2d3/TTmihYtsLMnO1W3L24dP2Vru10F BwKpL1AZQLb+i2b3vir819LpoQ== X-Google-Smtp-Source: ABdhPJztg2JZ0lfPBKpRS5e6PcjYOMvW4/3r4DT52HfPZ2N9pX0RvjFWOsn0Ee82mHqUxfdIURFLbw== X-Received: by 2002:a02:11c9:: with SMTP id 192mr7529596jaf.135.1616679530405; Thu, 25 Mar 2021 06:38:50 -0700 (PDT) Received: from [192.168.1.30] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id v7sm2770160ilu.72.2021.03.25.06.38.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Mar 2021 06:38:50 -0700 (PDT) Subject: Re: [PATCH AUTOSEL 5.11 43/44] signal: don't allow STOP on PF_IO_WORKER threads To: Stefan Metzmacher , "Eric W. Biederman" Cc: Sasha Levin , linux-kernel@vger.kernel.org, stable@vger.kernel.org, io-uring , Linus Torvalds References: <20210325112459.1926846-1-sashal@kernel.org> <20210325112459.1926846-43-sashal@kernel.org> <41589c56-9219-3ec2-55b3-3f010752ac7b@samba.org> From: Jens Axboe Message-ID: <2b2a9701-cbe0-4538-ed3b-6917b85bebf8@kernel.dk> Date: Thu, 25 Mar 2021 07:38:51 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <41589c56-9219-3ec2-55b3-3f010752ac7b@samba.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 3/25/21 6:11 AM, Stefan Metzmacher wrote: > > Am 25.03.21 um 13:04 schrieb Eric W. Biederman: >> Stefan Metzmacher writes: >> >>> Am 25.03.21 um 12:24 schrieb Sasha Levin: >>>> From: "Eric W. Biederman" >>>> >>>> [ Upstream commit 4db4b1a0d1779dc159f7b87feb97030ec0b12597 ] >>>> >>>> Just like we don't allow normal signals to IO threads, don't deliver a >>>> STOP to a task that has PF_IO_WORKER set. The IO threads don't take >>>> signals in general, and have no means of flushing out a stop either. >>>> >>>> Longer term, we may want to look into allowing stop of these threads, >>>> as it relates to eg process freezing. For now, this prevents a spin >>>> issue if a SIGSTOP is delivered to the parent task. >>>> >>>> Reported-by: Stefan Metzmacher >>>> Signed-off-by: Jens Axboe >>>> Signed-off-by: "Eric W. Biederman" >>>> Signed-off-by: Sasha Levin >>>> --- >>>> kernel/signal.c | 3 ++- >>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/kernel/signal.c b/kernel/signal.c >>>> index 55526b941011..00a3840f6037 100644 >>>> --- a/kernel/signal.c >>>> +++ b/kernel/signal.c >>>> @@ -288,7 +288,8 @@ bool task_set_jobctl_pending(struct task_struct *task, unsigned long mask) >>>> JOBCTL_STOP_SIGMASK | JOBCTL_TRAPPING)); >>>> BUG_ON((mask & JOBCTL_TRAPPING) && !(mask & JOBCTL_PENDING_MASK)); >>>> >>>> - if (unlikely(fatal_signal_pending(task) || (task->flags & PF_EXITING))) >>>> + if (unlikely(fatal_signal_pending(task) || >>>> + (task->flags & (PF_EXITING | PF_IO_WORKER)))) >>>> return false; >>>> >>>> if (mask & JOBCTL_STOP_SIGMASK) >>>> >>> >>> Again, why is this proposed for 5.11 and 5.10 already? >> >> Has the bit about the io worker kthreads been backported? >> If so this isn't horrible. If not this is nonsense. No not yet - my plan is to do that, but not until we're 100% satisfied with it. > I don't know, I hope not... > > But I just tested v5.12-rc4 and attaching to > an application with iothreads with gdb is still not possible, > it still loops forever trying to attach to the iothreads. I do see the looping, gdb apparently doesn't give up when it gets -EPERM trying to attach to the threads. Which isn't really a kernel thing, but: > And I tested 'kill -9 $pidofiothread', and it feezed the whole > machine... that sounds very strange, I haven't seen anything like that running the exact same scenario. > So there's still work to do in order to get 5.12 stable. > > I'm short on time currently, but I hope to send more details soon. Thanks! I'll play with it this morning and see if I can provoke something odd related to STOP/attach. -- Jens Axboe