From: Jens Axboe <[email protected]>
To: Al Viro <[email protected]>
Cc: [email protected],
Pavel Begunkov <[email protected]>,
[email protected],
Linus Torvalds <[email protected]>
Subject: Re: [RFC][PATCH] fix io_uring_show_fdinfo() misuse of ->d_iname
Date: Sun, 19 Jan 2025 07:28:02 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <20250119032649.GW1977892@ZenIV>
On 1/18/25 8:26 PM, Al Viro wrote:
> Output of io_uring_show_fdinfo() has several problems:
> * racy use of ->d_iname
> * junk if the name is long - in that case it's not stored in ->d_iname
> at all
> * lack of quoting (names can contain newlines, etc. - or be equal to "<none>",
> for that matter).
> * lines for empty slots are pointless noise - we already have the total
> amount, so having just the non-empty ones would carry the same information.
Thanks Al, I'll queue this up.
--
Jens Axboe
prev parent reply other threads:[~2025-01-19 14:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-18 2:57 [RFC][PATCH] fix io_uring_show_fdinfo() misuse of ->d_iname Al Viro
2025-01-18 15:02 ` Jens Axboe
2025-01-19 3:26 ` Al Viro
2025-01-19 14:28 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox