From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B1DDC433EF for ; Thu, 19 May 2022 12:13:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236765AbiESMNo (ORCPT ); Thu, 19 May 2022 08:13:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237727AbiESMNn (ORCPT ); Thu, 19 May 2022 08:13:43 -0400 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89CDC7A833 for ; Thu, 19 May 2022 05:13:39 -0700 (PDT) Received: by mail-pg1-x530.google.com with SMTP id a19so4884319pgw.6 for ; Thu, 19 May 2022 05:13:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=GmxU/O4H+JSo5ZKNu9jJfb7kEf/L0HWTXfgb5nJEI4A=; b=sz+8NS0oKVCMtxCEB3zMr4WcExVRYRwmes1vCmNLo9ZcKbhNqkegnftUzYTbRPn+hQ sorenMoirs599Jk0WnvsEDRa0zgWwPIe/9Rhr7UwsDYJKUDxIOXbvVv6walL4+keACp2 U82Fwu6X5fgbHr5b5gmOUv71jOPQng438qqeST8POgtp/8L+qUxKAsPQMZj5i3VBtnLo rqKMyOFiryvHj3CX9iMUNEuRTm6ReaTUVmZ7Kyh144qxazmqpXed64CkyihgPSEFecP1 v5iHpWVwPG5Okt2vlfeMmpu3Nxmh/kPmWFBke9dgcD5Q0Pxhn23F9wZ7RI3fL7n4SA0m YWpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=GmxU/O4H+JSo5ZKNu9jJfb7kEf/L0HWTXfgb5nJEI4A=; b=swgQNCZGKo3yBtCSbS//dzl8Pls3vw975bN3K6Y0Ik4L7VH8zgpeUpN7Qx9VXiTygh 2ZoreyO8L6lyTlEZg0TetMieB/V1O9cdFM4k4ATHLEr8UXAc7H5lSiOVOLL9VZq5c7Bs p00F5qvTff2KN2yrjN5LxW5M07MAmyS+lnTsvS0P5eXP8pod9suDXad9KMMZs2ppsSMQ oredaF3nM+IroYG/wAwY3DPhjblG7BxRc2sz5eSpI8QQDOOznTWjYbk00Xgrm2VJ5RNV e1v/qrz6JYyv/4Jdp3Q4SGfhNTBVcSQQuzZ5FM38LWsqjRMEhWUOzgVVnfWPcdCMELIB AXOA== X-Gm-Message-State: AOAM531FuU6pjCPVA8WKYCGJz0YfcsyPJqwOauF7l1Yf1tJFE1GeVwbO ph2MHLUaXFLBs1EfhKIQHjUkSA== X-Google-Smtp-Source: ABdhPJz8koyl6XwSJRRbtRGGZWml3c3PXKgPxSUA2t3E7U720nQRtSKdiKOubbLtMZSQNzbv9qvhpQ== X-Received: by 2002:a65:4904:0:b0:3c6:86c7:317b with SMTP id p4-20020a654904000000b003c686c7317bmr3663485pgs.39.1652962418776; Thu, 19 May 2022 05:13:38 -0700 (PDT) Received: from [192.168.1.100] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id z17-20020a170903409100b0016173113c50sm3524333plc.92.2022.05.19.05.13.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 May 2022 05:13:38 -0700 (PDT) Message-ID: <2eb22fb3-40cc-48f6-8ba9-5faeae0b43ff@kernel.dk> Date: Thu, 19 May 2022 06:13:36 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2] io_uring: fix sparce warnings about __kernel_rwf_t casts Content-Language: en-US To: Christoph Hellwig , Vasily Averin Cc: kernel@openvz.org, linux-kernel@vger.kernel.org, Pavel Begunkov , Steven Rostedt , Ingo Molnar , io-uring@vger.kernel.org References: <7de7721b-d090-6400-9a74-30ecb696761b@openvz.org> From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 5/19/22 1:03 AM, Christoph Hellwig wrote: >> index cddf5b6fbeb4..34839f30caee 100644 >> --- a/include/trace/events/io_uring.h >> +++ b/include/trace/events/io_uring.h >> @@ -520,7 +520,7 @@ TRACE_EVENT(io_uring_req_failed, >> __entry->off = sqe->off; >> __entry->addr = sqe->addr; >> __entry->len = sqe->len; >> - __entry->op_flags = sqe->rw_flags; >> + __entry->op_flags = sqe->poll32_events; >> __entry->buf_index = sqe->buf_index; >> __entry->personality = sqe->personality; >> __entry->file_index = sqe->file_index; > > For which I did not see a warning even if it looks real to me. > But this union with basically a lot of __u32s here looks pretty > strange to start with to me. Vasily, if this is still causing unnecessary sparse spews, please send a revised one against the current branch. The union is the per-op flags. The requests that use them have a member in there, either one can be used for printing it obviously. -- Jens Axboe