From: Jens Axboe <[email protected]>
To: Stefan Metzmacher <[email protected]>,
Ming Lei <[email protected]>,
[email protected], Pavel Begunkov <[email protected]>
Cc: David Ahern <[email protected]>
Subject: Re: IOSQE_IO_LINK vs. short send of SOCK_STREAM
Date: Wed, 11 Jan 2023 09:36:07 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 1/11/23 9:32 AM, Stefan Metzmacher wrote:
> Hi Ming,
>
>> Per my understanding, a short send on SOCK_STREAM should terminate the
>> remainder of the SQE chain built by IOSQE_IO_LINK.
>>
>> But from my observation, this point isn't true when using io_sendmsg or
>> io_sendmsg_zc on TCP socket, and the other remainder of the chain still
>> can be completed after one short send is found. MSG_WAITALL is off.
>
> This is due to legacy reasons, you need pass MSG_WAITALL explicitly
> in order to a retry or an error on a short write...
> It should work for send, sendmsg, sendmsg_zc, recv and recvmsg.
Dylan and I were just discussing this OOB and was hoping you'd chime
in, as I had some recollection that you were involved with this one.
We should probably ensure this is adequately documented, as it isn't
immediately obvious that you'd need WAITALL for links to work with
receives.
> For recv and recvmsg MSG_WAITALL also fails the link for MSG_TRUNC and MSG_CTRUNC.
>
> metze
>
--
Jens Axboe
next prev parent reply other threads:[~2023-01-11 16:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 15:26 IOSQE_IO_LINK vs. short send of SOCK_STREAM Ming Lei
2023-01-11 15:49 ` Jens Axboe
2023-01-11 16:32 ` Stefan Metzmacher
2023-01-11 16:36 ` Jens Axboe [this message]
2023-01-12 3:27 ` Ming Lei
2023-01-12 3:40 ` Jens Axboe
2023-01-12 7:35 ` Stefan Metzmacher
2023-01-13 10:12 ` Ming Lei
2023-01-13 17:51 ` Jens Axboe
2023-01-13 18:01 ` Jens Axboe
2023-01-14 0:27 ` Ming Lei
2023-01-14 1:39 ` Ming Lei
2023-01-14 2:12 ` Ming Lei
2023-01-14 3:47 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox