public inbox for [email protected]
 help / color / mirror / Atom feed
* [PATCH liburing] tests: identify timed out tests correctly
@ 2021-01-04 20:34 Pavel Begunkov
  2021-01-06 18:40 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Pavel Begunkov @ 2021-01-04 20:34 UTC (permalink / raw)
  To: Jens Axboe, io-uring

We want to get a stable status (i.e. -124) when a test has timed out,
but --preserve-status makes it to return whatever the process got.
Remove the flag, it behaves same but if timed out passes back -124.

Signed-off-by: Pavel Begunkov <[email protected]>
---
 test/runtests.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/runtests.sh b/test/runtests.sh
index fa240f2..7ed8852 100755
--- a/test/runtests.sh
+++ b/test/runtests.sh
@@ -84,7 +84,7 @@ run_test()
 	fi
 
 	# Run the test
-	timeout --preserve-status -s INT -k $TIMEOUT $TIMEOUT ./$test_name $dev
+	timeout -s INT -k $TIMEOUT $TIMEOUT ./$test_name $dev
 	local status=$?
 
 	# Check test status
-- 
2.24.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH liburing] tests: identify timed out tests correctly
  2021-01-04 20:34 [PATCH liburing] tests: identify timed out tests correctly Pavel Begunkov
@ 2021-01-06 18:40 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2021-01-06 18:40 UTC (permalink / raw)
  To: Pavel Begunkov, io-uring

On 1/4/21 1:34 PM, Pavel Begunkov wrote:
> We want to get a stable status (i.e. -124) when a test has timed out,
> but --preserve-status makes it to return whatever the process got.
> Remove the flag, it behaves same but if timed out passes back -124.

Applied, thanks.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-01-06 18:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-04 20:34 [PATCH liburing] tests: identify timed out tests correctly Pavel Begunkov
2021-01-06 18:40 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox