public inbox for [email protected]
 help / color / mirror / Atom feed
From: Jens Axboe <[email protected]>
To: Constantine Gavrilov <[email protected]>
Cc: "[email protected]" <[email protected]>
Subject: Re: io_uring_enter() with opcode IORING_OP_RECV ignores MSG_WAITALL in msg_flags
Date: Wed, 23 Mar 2022 06:38:08 -0600	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <DM6PR15MB2603FB4275378379A6010323FA189@DM6PR15MB2603.namprd15.prod.outlook.com>

(please don't top post, replies go below the text you're replying to)

On 3/23/22 6:32 AM, Constantine Gavrilov wrote:
> Yes, I have a real test case. I cannot share it vebratim, but with a
> little effort I believe I can come with a simple code of
> client/server.
> 
> It seems the issue shall be directly seen from the implementation, but
> if it is not so, I will provide a sample code.

If you can, that would be useful. I took a quick look, and recv and
recvmsg handle this similarly. Are you seeing a short return, or is the
data wrong?

A bug report with a test case is always infinitely more vauable than one
that does not have one. It serves two purposes:

1) It more accurately tells us what the submitter thinks is wrong (eg
   the "this is what I expected, but this is what happened").

2) It means that we don't have to write one, which saves a lot of time.
   Ideally we end up putting it into the regression tests, which helps
   to guarantee it won't regress there again.

While you may think that we can just look at the code and fix it, a fix
needs a regression test too. And that now means that we have to write
that too...

> Forgot to mention that the issue is seen of Fedora kernel version
> 5.16.12-200.fc35.x86_64.

Thanks, forgot to ask, that's useful to know.

-- 
Jens Axboe


  reply	other threads:[~2022-03-23 12:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <BYAPR15MB260078EC747F0F0183D1BB1BFA189@BYAPR15MB2600.namprd15.prod.outlook.com>
2022-03-23 12:19 ` io_uring_enter() with opcode IORING_OP_RECV ignores MSG_WAITALL in msg_flags Jens Axboe
2022-03-23 12:32   ` Constantine Gavrilov
2022-03-23 12:38     ` Jens Axboe [this message]
     [not found]     ` <DM6PR15MB2603162E692B5A68A4FD0A6FFA189@DM6PR15MB2603.namprd15.prod.outlook.com>
2022-03-23 13:12       ` Constantine Gavrilov
2022-03-23 15:25         ` Jens Axboe
2022-03-23 19:40   ` Pavel Begunkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox