From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>,
Yuhao Jiang <danisjiang@gmail.com>
Cc: io-uring@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2] io_uring/rsrc: fix RLIMIT_MEMLOCK bypass by removing cross-buffer accounting
Date: Sat, 24 Jan 2026 08:55:43 -0700 [thread overview]
Message-ID: <32b884bc-929b-4b27-ae74-5754fa2473de@kernel.dk> (raw)
In-Reply-To: <74f2ec89-ca40-44a0-8df7-de404063a1a3@kernel.dk>
On 1/24/26 8:14 AM, Jens Axboe wrote:
>>> ________________________________________________________
>>> Executed in 2.81 secs fish external
>>> usr time 0.71 secs 497.00 micros 0.71 secs
>>> sys time 19.57 secs 183.00 micros 19.57 secs
>>>
>>> which isn't insane. Obviously also needs conditional rescheduling in the
>>> page loops, as those can take a loooong time for large amounts of
>>> memory.
>>
>> 2.8 sec sounds like a lot as well, makes me wonder which part of
>> that is mm, but it mm should scale fine-ish. Surely there will be
>> contention on page refcounts but at least the table walk is
>> lockless in the best case scenario and otherwise seems to be read
>> protected by an rw lock.
>
> Well a lot of that is also just faulting in the memory on clear, test
> case should probably be modified to do its own timing. And iterating
> page arrays is a huge part of it too. There's no real contention in that
> 2.8 seconds.
I checked and the faulting part is 2.0s of that runtime. On a re-run:
axboe@r7625 ~> time ./ppage 32 32
register 32 GB, num threads 32
clear msec 2011
________________________________________________________
Executed in 3.13 secs fish external
usr time 0.78 secs 193.00 micros 0.78 secs
sys time 27.46 secs 271.00 micros 27.46 secs
Or just a single thread:
axboe@r7625 ~> time ./ppage 32 1
register 32 GB, num threads 1
clear msec 2081
________________________________________________________
Executed in 2.29 secs fish external
usr time 0.58 secs 750.00 micros 0.58 secs
sys time 1.71 secs 0.00 micros 1.71 secs
axboe@r7625 ~ [1]> time ./ppage 64 1
register 64 GB, num threads 1
clear msec 5380
________________________________________________________
Executed in 6.24 secs fish external
usr time 1.42 secs 328.00 micros 1.42 secs
sys time 4.82 secs 375.00 micros 4.82 secs
--
Jens Axboe
next prev parent reply other threads:[~2026-01-24 15:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-19 7:10 [PATCH v2] io_uring/rsrc: fix RLIMIT_MEMLOCK bypass by removing cross-buffer accounting Yuhao Jiang
2026-01-19 17:03 ` Jens Axboe
2026-01-19 23:34 ` Yuhao Jiang
2026-01-19 23:40 ` Jens Axboe
2026-01-20 7:05 ` Yuhao Jiang
2026-01-20 12:04 ` Jens Axboe
2026-01-20 12:05 ` Pavel Begunkov
2026-01-20 17:03 ` Jens Axboe
2026-01-20 21:45 ` Pavel Begunkov
2026-01-21 14:58 ` Jens Axboe
2026-01-22 11:43 ` Pavel Begunkov
2026-01-22 17:47 ` Jens Axboe
2026-01-22 21:51 ` Pavel Begunkov
2026-01-23 14:26 ` Pavel Begunkov
2026-01-23 14:50 ` Jens Axboe
2026-01-23 15:04 ` Jens Axboe
2026-01-23 16:52 ` Jens Axboe
2026-01-24 11:04 ` Pavel Begunkov
2026-01-24 15:14 ` Jens Axboe
2026-01-24 15:55 ` Jens Axboe [this message]
2026-01-24 16:30 ` Pavel Begunkov
2026-01-24 18:44 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32b884bc-929b-4b27-ae74-5754fa2473de@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=danisjiang@gmail.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox