Re: [PATCH] io_uring/register: use correct location for io_rings_layout

[Jens Axboe <axboe@kernel.dk>]

On 11/19/25 10:18 AM, Pavel Begunkov wrote:
> On 11/19/25 02:36, Jens Axboe wrote:
>> A previous consolidated the ring size etc calculations into
>> io_prepare_config(), but missed updating io_register_resize_rings()
>> correctly to use the calculated values. As a result, it ended up using
>> on-stack uninitialized values, and hence either failed validating the
>> size correctly, or just failed resizing because the sizes were random.
>>
>> This caused failures in the liburing regression tests:
> 
> That made me wonder how it could possibly pass tests for me. I even
> made sure it was reaching the final return. Turns out the layout was
> 0 initialised, region creation fails with -EINVAL, and then the
> resizing test just silently skips sub-cases. It'd be great to have
> a "not supported, skip" message.

Looks like the test runs into -EINVAL, then tries the DEFER case,
and then doesn't check for SKIP for that. And then it returns
success. I've added a commit for that now, so it'll return 77/SKIP
if it does skip.

I try to avoid having tests be verbose, unless they fail. Otherwise
it's easy to lose information you actually want in the noise. But
it certainly should return T_EXIT_SKIP, when it skips!

-- 
Jens Axboe