From: Jens Axboe <[email protected]>
To: Stefan Roesch <[email protected]>, [email protected]
Cc: [email protected], [email protected],
[email protected], [email protected]
Subject: Re: [PATCH v5 2/3] io_uring: add api to set / get napi configuration.
Date: Mon, 21 Nov 2022 12:46:40 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 11/21/22 12:14?PM, Stefan Roesch wrote:
> +static int io_unregister_napi(struct io_ring_ctx *ctx, void __user *arg)
> +{
> +#ifdef CONFIG_NET_RX_BUSY_POLL
> + const struct io_uring_napi curr = {
> + .busy_poll_to = ctx->napi_busy_poll_to,
> + };
> +
> + if (copy_to_user(arg, &curr, sizeof(curr)))
> + return -EFAULT;
> +
> + WRITE_ONCE(ctx->napi_busy_poll_to, 0);
> + return 0;
> +#else
> + return -EINVAL;
> +#endif
> +}
Should probably check resv/pad here as well, maybe even the
'busy_poll_to' being zero?
--
Jens Axboe
next prev parent reply other threads:[~2022-11-21 19:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 19:14 [PATCH v5 0/3] io_uring: add napi busy polling support Stefan Roesch
2022-11-21 19:14 ` [PATCH v5 1/3] " Stefan Roesch
2022-11-21 19:45 ` Jens Axboe
2022-11-21 23:59 ` Jens Axboe
2022-11-21 19:14 ` [PATCH v5 2/3] io_uring: add api to set / get napi configuration Stefan Roesch
2022-11-21 19:46 ` Jens Axboe [this message]
2022-11-22 13:13 ` Ammar Faizi
2022-11-22 13:19 ` Jens Axboe
2022-11-25 21:43 ` Ammar Faizi
2022-11-28 20:22 ` Stefan Roesch
2022-11-21 19:14 ` [PATCH v5 3/3] io_uring: add api to set napi prefer busy poll Stefan Roesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox