From: Jens Axboe <[email protected]>
To: Ammar Faizi <[email protected]>,
Pavel Begunkov <[email protected]>,
[email protected]
Cc: Olivier Langlois <[email protected]>
Subject: Re: [PATCH] Fix typo "timout" -> "timeout"
Date: Tue, 5 Oct 2021 16:41:21 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 10/5/21 4:30 PM, Ammar Faizi wrote:
> Cc: Jens Axboe <[email protected]>
> Cc: Olivier Langlois <[email protected]>
> Fixes: a060c8e55a6116342a16b5b6ac0c4afed17c1cd7 ("liburing: Add io_uring_submit_and_wait_timeout function in API")
> Signed-off-by: Ammar Faizi <[email protected]>
> ---
>
> It seems Olivier got rushed a bit when writing this. How did you
> test this?
Ugh indeed. Olivier, did you test this at all? I missed this when reviewing
it, but I would assume that writing a separate test would have caught it.
Said test should go into liburing as well, fwiw. Can you please submit it?
--
Jens Axboe
next prev parent reply other threads:[~2021-10-05 22:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 16:56 [PATCH v2] liburing: Add io_uring_submit_and_wait_timeout function in API Olivier Langlois
2021-10-04 23:32 ` Jens Axboe
2021-10-05 22:30 ` [PATCH] Fix typo "timout" -> "timeout" Ammar Faizi
2021-10-05 22:41 ` Jens Axboe [this message]
2021-12-06 19:45 ` Olivier Langlois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox