From: Jens Axboe <axboe@kernel.dk>
To: Caleb Sander Mateos <csander@purestorage.com>
Cc: io-uring@vger.kernel.org, asml.silence@gmail.com
Subject: Re: [PATCH 5/5] io_uring: add new helpers for posting overflows
Date: Fri, 16 May 2025 17:49:15 -0600 [thread overview]
Message-ID: <35dbfe01-3aca-4096-9d96-9666b70428aa@kernel.dk> (raw)
In-Reply-To: <CADUfDZq19zOMkX2ZnaAuftb=jCGXRfje+UNu9xmR3gnGBSACMA@mail.gmail.com>
On 5/16/25 5:17 PM, Caleb Sander Mateos wrote:
>> @@ -808,6 +808,27 @@ static bool io_fill_cqe_aux(struct io_ring_ctx *ctx, u64 user_data, s32 res,
>> return false;
>> }
>>
>> +static __cold void io_cqe_overflow_lockless(struct io_ring_ctx *ctx,
>> + struct io_cqe *cqe,
>> + struct io_big_cqe *big_cqe)
>
> Naming nit: "lockless" seems a bit misleading since this does still
> take the completion_lock. Maybe name this function "io_cqe_overflow()"
> and the other "io_cqe_overflow_locked()"?
Only reason why I chose lockless is to match the ctx member for the
same. But yes, you're suggestion is probably better. I'll mull it over
and change it regardless.
> Otherwise,
>
> Reviewed-by: Caleb Sander Mateos <csander@purestorage.com>
Thanks!
--
Jens Axboe
next prev parent reply other threads:[~2025-05-16 23:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-16 20:05 [PATCHSET v3 0/5] Allow non-atomic allocs for overflows Jens Axboe
2025-05-16 20:05 ` [PATCH 1/5] io_uring: open code io_req_cqe_overflow() Jens Axboe
2025-05-16 20:05 ` [PATCH 2/5] io_uring: split alloc and add of overflow Jens Axboe
2025-05-16 23:00 ` Caleb Sander Mateos
2025-05-16 20:05 ` [PATCH 3/5] io_uring: make io_alloc_ocqe() take a struct io_cqe pointer Jens Axboe
2025-05-16 23:07 ` Caleb Sander Mateos
2025-05-16 23:08 ` Caleb Sander Mateos
2025-05-16 23:48 ` Jens Axboe
2025-05-16 20:05 ` [PATCH 4/5] io_uring: pass in struct io_big_cqe to io_alloc_ocqe() Jens Axboe
2025-05-16 23:10 ` Caleb Sander Mateos
2025-05-16 20:05 ` [PATCH 5/5] io_uring: add new helpers for posting overflows Jens Axboe
2025-05-16 23:17 ` Caleb Sander Mateos
2025-05-16 23:49 ` Jens Axboe [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-05-17 11:42 [PATCHSET v4 0/5] Allow non-atomic allocs for overflows Jens Axboe
2025-05-17 11:42 ` [PATCH 5/5] io_uring: add new helpers for posting overflows Jens Axboe
2025-05-17 23:32 ` Caleb Sander Mateos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35dbfe01-3aca-4096-9d96-9666b70428aa@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=csander@purestorage.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox