From: Jens Axboe <[email protected]>
To: Pavel Begunkov <[email protected]>, [email protected]
Cc: [email protected]
Subject: Re: [PATCH 1/1] io_uring: don't re-read iovecs in iopoll_complete
Date: Thu, 25 Feb 2021 07:58:04 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <3b8aa8f6cfcad71b8a633477932e34232ade68d8.1614257829.git.asml.silence@gmail.com>
On 2/25/21 6:02 AM, Pavel Begunkov wrote:
> Issuing a request for IO poll and doing actual IO polling might be done
> from different syscalls, so userspace's iovec used during submission may
> already be gone by the moment of reaping the request and doing reissue
> with prep inside is not always safe.
>
> Fail IO poll reissue with -EAGAIN for requests that would need to read
> iovec from the userspace. The userspace have to check for it, so it's
> fine.
That looks fine, we can't be off the submit path at that point, so
should get -EAGAIN if we don't have the state we need.
--
Jens Axboe
prev parent reply other threads:[~2021-02-25 14:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 13:02 [PATCH 1/1] io_uring: don't re-read iovecs in iopoll_complete Pavel Begunkov
2021-02-25 14:58 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox