public inbox for [email protected]
 help / color / mirror / Atom feed
From: Jens Axboe <[email protected]>
To: Yin Fengwei <[email protected]>, io-uring <[email protected]>
Subject: Re: [PATCH] io_uring: ensure REQ_F_ISREG is set async offload
Date: Thu, 21 Jul 2022 19:36:02 -0600	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 7/21/22 5:43 PM, Yin Fengwei wrote:
> 
> On 7/21/2022 11:11 PM, Jens Axboe wrote:
>> If we're offloading requests directly to io-wq because IOSQE_ASYNC was
>> set in the sqe, we can miss hashing writes appropriately because we
>> haven't set REQ_F_ISREG yet. This can cause a performance regression
>> with buffered writes, as io-wq then no longer correctly serializes writes
>> to that file.
>>
>> Ensure that we set the flags in io_prep_async_work(), which will cause
>> the io-wq work item to be hashed appropriately.
>>
>> Fixes: 584b0180f0f4 ("io_uring: move read/write file prep state into actual opcode handler")
>> Link: https://lore.kernel.org/io-uring/20220608080054.GB22428@xsang-OptiPlex-9020/
>> Reported-and-tested-by: Yin Fengwei <[email protected]>
> This issue is reported by (from the original report):
> 
> If you fix the issue, kindly add following tag
> Reported-by: kernel test robot <[email protected]>

Sorry, I missed that in the original. I'll be rebasing this branch this
weekend anyway, I'll try and remember to make the edit.

-- 
Jens Axboe


      reply	other threads:[~2022-07-22  1:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-21 15:11 [PATCH] io_uring: ensure REQ_F_ISREG is set async offload Jens Axboe
2022-07-21 23:43 ` Yin Fengwei
2022-07-22  1:36   ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox