From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B7BBC433DB for ; Sat, 23 Jan 2021 23:34:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 47E3622CF6 for ; Sat, 23 Jan 2021 23:34:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726375AbhAWXeY (ORCPT ); Sat, 23 Jan 2021 18:34:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726204AbhAWXeS (ORCPT ); Sat, 23 Jan 2021 18:34:18 -0500 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63930C0613D6 for ; Sat, 23 Jan 2021 15:33:38 -0800 (PST) Received: by mail-pl1-x635.google.com with SMTP id h15so2903608pli.8 for ; Sat, 23 Jan 2021 15:33:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=cZSjZ1gWlL041uFW/1i9ltjoZrL1VhC51p2h42FCoWs=; b=wqjRxvWDXSOXa4u0cPIKuxpGfZnfoQofsTeIqY3GBU3H20Ouu06BeGsM/cUKieNeg+ LmxH2PDFQ0RMulHva9w0puXRGhqdfiQbPMxDcAJcwT8xI4hn/LuKbj3nGY1OyBrT/och H5vyKm1MOOKlNMexECHrbIyP8UwWKyR3Qd8gc9+4SRx3pWsajahJfFtCudvpdGbuOgAn 5VM7Amj/PB0dYZdOeq3YMz4sXMC4EGAVl5j3sU0NNHYS8VTW7nDBn1POObze1A2CYn5b sHvOuOsslvu7UM4VQUJIIJIza2CHijCDSYZcpLwNtiQNapmf9898J/hcIGJ/iVvkNLAl rtdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=cZSjZ1gWlL041uFW/1i9ltjoZrL1VhC51p2h42FCoWs=; b=Slf2yacm9nfXApgcZWu9YM/Vt00WMTFv01KM85Mj41Tv1hyHEGwOK8+HXxSU/SyS5D wty4b3jYnOtCzRSYuKmplkEIDorrNDeNQ0/kdgYCTOGiBlSn+59i2T3gxZEiyu8JGRsS dhRclPk9g0rdwyoCjABfPtzXA9fYE2tc5KDAETx+d02r5CRr05KAPw3gsnElZr9QBTj2 ZRHeAHFz1p+FNSPycxdeib2NXSZQRbm+GQ+2vZqUNgbNn6FPZMf5yyClPu1EYCOtQhHk OOL7DoJcMyTgHA2UDx80isKjsSYEsx8SMtXTpNooHAOIhsjy02KF/wA7Pzm6uoEWVOhQ J68Q== X-Gm-Message-State: AOAM531dnNFFuIE7kOLZwpyWj23ldauKrNnJHNKJEluwgqbF1e3gP+xS IfKxjhFUmR2GeY+8R5Sq4EoNOQ== X-Google-Smtp-Source: ABdhPJwCuduVl6ChCtvQUWbdWIg0nuNpqd3VITA6h3x1iChRUwtmEe3RTcsP2YLvfEf1S86o06nw3A== X-Received: by 2002:a17:90a:5911:: with SMTP id k17mr13620918pji.152.1611444817711; Sat, 23 Jan 2021 15:33:37 -0800 (PST) Received: from [192.168.4.41] (cpe-72-132-29-68.dc.res.rr.com. [72.132.29.68]) by smtp.gmail.com with ESMTPSA id g22sm9010746pfu.200.2021.01.23.15.33.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 23 Jan 2021 15:33:37 -0800 (PST) Subject: Re: [RFC PATCH] io_uring: add support for IORING_OP_GETDENTS64 To: Matthew Wilcox , Lennert Buytenhek Cc: linux-kernel@vger.kernel.org, io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org References: <20210123114152.GA120281@wantstofly.org> <20210123232754.GA308988@casper.infradead.org> From: Jens Axboe Message-ID: <39a9b1da-bbcc-daa0-12e9-3eb776658564@kernel.dk> Date: Sat, 23 Jan 2021 16:33:34 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210123232754.GA308988@casper.infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 1/23/21 4:27 PM, Matthew Wilcox wrote: > On Sat, Jan 23, 2021 at 01:41:52PM +0200, Lennert Buytenhek wrote: >> IORING_OP_GETDENTS64 behaves like getdents64(2) and takes the same > > Could we drop the '64'? We don't, for example, have IOURING_OP_FADVISE64 > even though that's the name of the syscall. Agreed, only case we do mimic the names are for things like IORING_OP_OPENAT2 where it does carry meaning. For this one, it should just be IORING_OP_GETDENTS. -- Jens Axboe