From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 739FB243964 for ; Mon, 17 Mar 2025 15:40:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742226011; cv=none; b=RICvA8+bGWQQn7b6VkaKEySIeTp9GC2H8seK6WWLRVWyLBb0aoSU1n4JUYAEzpl3d2gCOQkLF0NGF5P3Bxa9CJ3npxSQ/iF6F7mtaELgwfMt19hhlTcfQb1sMekORsfPV+Dnu3/xuN9j/56VewZ91K4neiMVSa4QY5ONM1vuovM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742226011; c=relaxed/simple; bh=Zk5t2sU0aCBaBnN0KQfk+cU/1BqX9as35kPCVJMUe5s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OrGs76Nd8L4sWKGOJp0hYBI89+8Z9PW1YSv3azrTgljMLWQC0ffSMoEgANhpZ1W9fQQ8YBmaYj8xIOLrRWhm28jrCDLyVdg2T5PIWOkGtmKozd/Tgp2v2TVUOr13wVOQX53M1vtvot6lkGt/2qBbhwa3XKe7CyS1GUre5YQms6Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=kFiRhRgN; arc=none smtp.client-ip=209.85.166.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="kFiRhRgN" Received: by mail-io1-f41.google.com with SMTP id ca18e2360f4ac-85b42db7b69so66010339f.0 for ; Mon, 17 Mar 2025 08:40:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1742226007; x=1742830807; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ShUy4m+vJwdS4QZv6PMnZsGbPGN8eu9awNnNG2yKLpU=; b=kFiRhRgNzlYLXTFW1ajt0pNhz9DF+aQlzqgUJJjkeLYlB/rikTzxYpiZKNtEsxGtAz uyaR8emXzgd7zLspKEn3Es3Cf5mhLu/I8Ifb7CQjYaho2geyPgnm2LbF9Se/st9lPZmU FplAekpsAhMQ1cZlS/IjZUho+xjDmibMaUNMs+x/Kusx9LMdSU5Kd/KrH8u+BHiorLfj 5QpZX4R2NcbbcKD43iuvOD+d6CEl8ykn8MzAYLIJkOGkIJWqaFLaQrYNEvH2mVZhjrVr pZlF/dBmRQKS3BrRsKk232JZmtJW+SQ3c4rpSnkkl1ax7cvGCHzFiVQhSL6oKPqtsIe3 uw7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742226007; x=1742830807; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ShUy4m+vJwdS4QZv6PMnZsGbPGN8eu9awNnNG2yKLpU=; b=hDqkuac/0k143ptMOVfdEJtpJcRGnXqkTe9NDaav5yFL/GpC2e5BWddSh+Ox6ecIRZ 2AqUqg7rZX94aHvn/9acSGwdA7gqYcSJi1Dr8ZpdfhBhD+ECa2bsF9GxGnnqYUqgQMbU ZNkrIWG8E33W9yVBFglnbc6MaKd8rhMo/Tmya5/9iauYJpvCXwBWnet2hSjedXluhcT1 ZL5eBZqtCQN49x7RXiOXVvlXZ+IOBV5wzBaQrVmInN+tpxq4XjD/fNppFqQReVuUze0s 4d2VWcH7kV3Ml3q+yKuGRFQgzBnjKVHGL40OxlMOsU3gfDZXwxhnBPX5YEBxeoti8A6m 0fXQ== X-Forwarded-Encrypted: i=1; AJvYcCVwnKzLjNjR4Iqux0Hda65KtvLOanZEvA4iVSabBJxLtvpjSV98ZVDPc5gZwxNmte7mNbXdWNQkhQ==@vger.kernel.org X-Gm-Message-State: AOJu0YyhAovKmMm4JgK8aGmfaWGy8dRtRZQBhdxZVWSrUHXONohA5QVi TNhRYBeaqTeQtTh0FmE8ljvfN2ER2TN1ZwgYHIpXN2c9t61Y+KmKRoCVOgSoB/8= X-Gm-Gg: ASbGncuncUPAPHhWPIyVf8xXastV8WjCop1bpksdiJMKS6XqvFjAYHZj+NFS5735hqW SpTHGYL1DYEG2Rtpam0VzcLSvrz38vr+gMKh8PvUvhbCoEpFV+TD5dZKDT02c6ten0sO8Nv2yZa W1/O90NeVt7GXHXW161N9O3wI/vanQKm5WbPlVvr+oZBevVVIirBfQ3NIcKtoXaRMm8EZ88D/iP op2wcQrX7WrEsZTd9UjuBWK9Q36GDJPPrCw1X7Y9R3xLVADz/n83msvJMP1BOTRotEPglXPwX4K X95gG8e7PsPNEcxCmjo53dWgiso9utGsFjm82sYaEXrIyoN1rUs= X-Google-Smtp-Source: AGHT+IHvdkWe+7JRGqXk+mUfmTZQ49tXHQzvD62kUaQdqYU4vxNYPeTNSe4s+5gD3xqVGJ1qX4dzzg== X-Received: by 2002:a05:6602:4147:b0:85b:505a:7e01 with SMTP id ca18e2360f4ac-85dc479224dmr1541106539f.5.1742226007242; Mon, 17 Mar 2025 08:40:07 -0700 (PDT) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4f2637031basm2315060173.2.2025.03.17.08.40.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Mar 2025 08:40:06 -0700 (PDT) Message-ID: <3a883e1e-d822-4c89-a7b0-f8802b8cc261@kernel.dk> Date: Mon, 17 Mar 2025 09:40:05 -0600 Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v4 4/5] btrfs: ioctl: introduce btrfs_uring_import_iovec() To: Sidong Yang , Josef Bacik , David Sterba , Pavel Begunkov Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, io-uring@vger.kernel.org References: <20250317135742.4331-1-sidong.yang@furiosa.ai> <20250317135742.4331-5-sidong.yang@furiosa.ai> Content-Language: en-US From: Jens Axboe In-Reply-To: <20250317135742.4331-5-sidong.yang@furiosa.ai> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/17/25 7:57 AM, Sidong Yang wrote: > This patch introduces btrfs_uring_import_iovec(). In encoded read/write > with uring cmd, it uses import_iovec without supporting fixed buffer. > btrfs_using_import_iovec() could use fixed buffer if cmd flags has > IORING_URING_CMD_FIXED. > > Signed-off-by: Sidong Yang > --- > fs/btrfs/ioctl.c | 32 ++++++++++++++++++++++++-------- > 1 file changed, 24 insertions(+), 8 deletions(-) > > diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c > index 6c18bad53cd3..a7b52fd99059 100644 > --- a/fs/btrfs/ioctl.c > +++ b/fs/btrfs/ioctl.c > @@ -4802,6 +4802,28 @@ struct btrfs_uring_encoded_data { > struct iov_iter iter; > }; > > +static int btrfs_uring_import_iovec(struct io_uring_cmd *cmd, > + unsigned int issue_flags, int rw) > +{ > + struct btrfs_uring_encoded_data *data = > + io_uring_cmd_get_async_data(cmd)->op_data; > + int ret; > + > + if (cmd && (cmd->flags & IORING_URING_CMD_FIXED)) { > + data->iov = NULL; > + ret = io_uring_cmd_import_fixed_vec(cmd, data->args.iov, > + data->args.iovcnt, > + ITER_DEST, issue_flags, > + &data->iter); > + } else { > + data->iov = data->iovstack; > + ret = import_iovec(rw, data->args.iov, data->args.iovcnt, > + ARRAY_SIZE(data->iovstack), &data->iov, > + &data->iter); > + } > + return ret; > +} How can 'cmd' be NULL here? -- Jens Axboe