From: Dan Carpenter <dan.carpenter@linaro.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Pavel Begunkov <asml.silence@gmail.com>,
io-uring@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: [PATCH 2/2] io_uring/net: remove unnecessary check
Date: Fri, 1 Mar 2024 18:29:52 +0300 [thread overview]
Message-ID: <3d17a814-2300-4902-8b2c-2a73c0e9bfc4@moroto.mountain> (raw)
In-Reply-To: <7f5d7887-f76e-4e68-98c2-894bfedbf292@moroto.mountain>
"namelen" is type size_t so it can't be negative.
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
io_uring/net.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/io_uring/net.c b/io_uring/net.c
index da257bf429d5..04a7426c80d2 100644
--- a/io_uring/net.c
+++ b/io_uring/net.c
@@ -557,8 +557,6 @@ static int io_recvmsg_mshot_prep(struct io_kiocb *req,
(REQ_F_APOLL_MULTISHOT|REQ_F_BUFFER_SELECT)) {
int hdr;
- if (unlikely(namelen < 0))
- return -EOVERFLOW;
if (check_add_overflow(sizeof(struct io_uring_recvmsg_out),
namelen, &hdr))
return -EOVERFLOW;
--
2.43.0
next prev parent reply other threads:[~2024-03-01 15:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 15:28 [PATCH 0/2] io_uring/net: fix bug in io_recvmsg_mshot_prep() Dan Carpenter
2024-03-01 15:29 ` [PATCH 1/2] io_uring/net: fix overflow check " Dan Carpenter
2024-03-01 15:29 ` Dan Carpenter [this message]
2024-03-01 16:56 ` [PATCH 2/2] io_uring/net: remove unnecessary check Dan Carpenter
2024-03-01 17:23 ` Jens Axboe
2024-03-01 15:55 ` [PATCH 0/2] io_uring/net: fix bug in io_recvmsg_mshot_prep() Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d17a814-2300-4902-8b2c-2a73c0e9bfc4@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox