From: Jens Axboe <axboe@kernel.dk>
To: Vishwanath Seshagiri <vishs@meta.com>
Cc: io-uring@vger.kernel.org, Vishwanath Seshagiri <vishs@fb.com>
Subject: Re: [PATCH] io_uring: add header include guards to all header files
Date: Tue, 17 Jun 2025 13:16:47 -0600 [thread overview]
Message-ID: <3fedba95-7a5d-45bb-b289-a2edc3d690e8@kernel.dk> (raw)
In-Reply-To: <20250617185001.1782992-1-vishs@meta.com>
On 6/17/25 12:50 PM, Vishwanath Seshagiri wrote:
> From: Vishwanath Seshagiri <vishs@fb.com>
>
> Add missing header include guards to all *.h files in the io_uring/
> directory to prevent multiple inclusion issues. This follows the
> established pattern used in io_uring/zcrx.h and other kernel headers.
>
> The guards use the format IOU_<NAME>_H to maintain consistency with
> the io_uring subsystem naming conventions.
It's quite on purpose they don't have guards - because they don't need
them. These headers are included by only C files, the ones that need a
guard would have them (eg ones potentially included in nested headers).
--
Jens Axboe
prev parent reply other threads:[~2025-06-17 19:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 18:50 [PATCH] io_uring: add header include guards to all header files Vishwanath Seshagiri
2025-06-17 19:16 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fedba95-7a5d-45bb-b289-a2edc3d690e8@kernel.dk \
--to=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=vishs@fb.com \
--cc=vishs@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox