Re: [PATCH 3/5] io_uring: make io_alloc_ocqe() take a struct io_cqe pointer

[Jens Axboe <axboe@kernel.dk>]

On 5/16/25 5:07 PM, Caleb Sander Mateos wrote:
> On Fri, May 16, 2025 at 1:10?PM Jens Axboe <axboe@kernel.dk> wrote:
>>
>> The number of arguments to io_alloc_ocqe() is a bit unwieldy. Make it
>> take a struct io_cqe pointer rather than three sepearate CQE args. One
> 
> typo: "separate"
> 
>> path already has that readily available, add an io_init_cqe() helper for
>> the remainding two.
> 
> typo: "remaining"

Thanks, will fix those.

>> @@ -806,6 +806,9 @@ static bool io_fill_cqe_aux(struct io_ring_ctx *ctx, u64 user_data, s32 res,
>>         return false;
>>  }
>>
>> +#define io_init_cqe(user_data, res, cflags)    \
>> +       (struct io_cqe) { .user_data = user_data, .res = res, .flags = cflags }
> 
> The arguments and result should be parenthesized to prevent unexpected
> groupings. Better yet, make this a static inline function.

Sure, will do (make it a static inline).

>> @@ -1444,8 +1449,7 @@ void __io_submit_flush_completions(struct io_ring_ctx *ctx)
>>                         gfp_t gfp = ctx->lockless_cq ? GFP_KERNEL : GFP_ATOMIC;
>>                         struct io_overflow_cqe *ocqe;
>>
>> -                       ocqe = io_alloc_ocqe(ctx, req->cqe.user_data, req->cqe.res,
>> -                                            req->cqe.flags, req->big_cqe.extra1,
>> +                       ocqe = io_alloc_ocqe(ctx, &req->cqe, req->big_cqe.extra1,
>>                                              req->big_cqe.extra2, gfp);
> 
> If the req->big_cqe type were named, these 2 arguments could be
> combined into just &req->big_cqe.

I see you saw the next patch post that, so will just ignore this one.

-- 
Jens Axboe