From: Jens Axboe <[email protected]>
To: Pavel Begunkov <[email protected]>, [email protected]
Subject: Re: [PATCH 5.12] io_uring: always go for cancellation spin on exec
Date: Sun, 28 Mar 2021 18:12:11 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <0a21bd6d794bb1629bc906dd57a57b2c2985a8ac.1616839147.git.asml.silence@gmail.com>
On 3/27/21 3:59 AM, Pavel Begunkov wrote:
> Always try to do cancellation in __io_uring_task_cancel() at least once,
> so it actually goes and cleans its sqpoll tasks (i.e. via
> io_sqpoll_cancel_sync()), otherwise sqpoll task may submit new requests
> after cancellation and it's racy for many reasons.
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2021-03-29 0:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-27 9:59 [PATCH 5.12] io_uring: always go for cancellation spin on exec Pavel Begunkov
2021-03-29 0:12 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox