From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-b1-smtp.messagingengine.com (fhigh-b1-smtp.messagingengine.com [202.12.124.152]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B37921DA3D; Sun, 19 Jan 2025 22:48:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.152 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737326885; cv=none; b=OUITs/L6wVdI3Ltpvp1p5ScJ6vArgSURGUve4OBnF4e+YVJNxeSRMZrRR0+TplnTdoquL2tS08fwBHkxKQsOIldpQmXHw1XP4WFiHvPw7YKi2Hfrvn1i5TPuivt9ELv2hJpHRKnh4MK0Dsi63YmC/0pW361w5ZDWnicLepHYJFc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737326885; c=relaxed/simple; bh=44XLgddyGklKb3yVswYOd+knU8casMeibni+ywOjpbw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=A6+U7rmNfmFabZvZ7IMmw6vIVq8At6tCOQF2H2zGoVe2cjikHdAHiEyRgqKgZ8ALYwDNwtBDi+TeEdxJZViy1ZSu3RCVYXsnqAckUpydYnooW/mOleOeTTRuxaQTEi+e7RUcwh2yM5lMOhPDAIiVIdrVCKc6R7FdBxXfBuS0A/M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bsbernd.com; spf=pass smtp.mailfrom=bsbernd.com; dkim=pass (2048-bit key) header.d=bsbernd.com header.i=@bsbernd.com header.b=OYuyddRs; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=cn8sdYHm; arc=none smtp.client-ip=202.12.124.152 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bsbernd.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bsbernd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bsbernd.com header.i=@bsbernd.com header.b="OYuyddRs"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="cn8sdYHm" Received: from phl-compute-11.internal (phl-compute-11.phl.internal [10.202.2.51]) by mailfhigh.stl.internal (Postfix) with ESMTP id 57F14254012D; Sun, 19 Jan 2025 17:48:01 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-11.internal (MEProxy); Sun, 19 Jan 2025 17:48:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsbernd.com; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1737326881; x=1737413281; bh=NOodp2GsviMLgahSg8J3SxByVXbKJ2CwIxqMmP0C/9Q=; b= OYuyddRsmbBE1dbLFatA7C0NmO0ieYTLzc0GFXrdFnq0YezWUgxQZr79nggC/pZ+ NnsKosVr0P/VrWRvTkcpobrG6Mjh80atYwji60BH/i+fPBbWPSDdcyJBkou7m+Gr a2vKYNJBsNkitTNWjsEKx1m2uNQiYBWPMfgxpW+4gc8yHlSUbPowULis3h/ydwo0 Wa8Ad8cA7ynWYyfqEtWR5AN00bAxZ7Pd3d4KOsHECo7MIGyL4Jn0f+V0IlI1DqxC cjABH5sI5VE+irjFq0R4LJEHdzNcfHXtkFHBUhltrFPpVPfbvthOHQYTpivEpoYr 58PeIrUBLzhZi8ojyvQOIA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1737326881; x= 1737413281; bh=NOodp2GsviMLgahSg8J3SxByVXbKJ2CwIxqMmP0C/9Q=; b=c n8sdYHm8rQ9aWBZnaqxvY1JCQCxK6U9O055dhFBz6WdFESi9jVKSTB16Mhz6ifPA DUXtg7Ta/Flq5t+B2xypuZpESrUWoZWLLejy1R+mIpN2PT5EAL3DGEIZAmP/vezy 2ttnhMAOlpE9GJwgVNd/rFE6dl8sg+WK2owwYD72CpsRS8mtIqw4pC4mR1QxnrKf Ug6EmJuH8pn3lYX8c0TYIgPa3PIJMAGHGPPQZRJexbVQbefJZqXtg4rb/7ONPlKk ihYijBNw3VAO/CwEfatWk+hpmCGVEsQy+5mTmxBNZjQXIrbL93O4HSmP+A5tgO+J PxIzdo3mCqiEaFLrf/eFA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrudeikedgtdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtvdej necuhfhrohhmpeeuvghrnhguucfutghhuhgsvghrthcuoegsvghrnhgusegsshgsvghrnh gurdgtohhmqeenucggtffrrghtthgvrhhnpeefgeegfeffkeduudelfeehleelhefgffeh udejvdfgteevvddtfeeiheeflefgvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrh grmhepmhgrihhlfhhrohhmpegsvghrnhgusegsshgsvghrnhgurdgtohhmpdhnsggprhgt phhtthhopeduuddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtoheprghsmhhlrdhsih hlvghntggvsehgmhgrihhlrdgtohhmpdhrtghpthhtohepsghstghhuhgsvghrthesuggu nhdrtghomhdprhgtphhtthhopehmihhklhhoshesshiivghrvgguihdrhhhupdhrtghpth htoheprgigsghovgeskhgvrhhnvghlrdgukhdprhgtphhtthhopehlihhnuhigqdhfshgu vghvvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtohepihhoqdhurhhinh hgsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtohepjhhorghnnhgvlhhkohho nhhgsehgmhgrihhlrdgtohhmpdhrtghpthhtohepjhhoshgvfhesthhogihitghprghnug grrdgtohhmpdhrtghpthhtoheprghmihhrjeefihhlsehgmhgrihhlrdgtohhm X-ME-Proxy: Feedback-ID: i5c2e48a5:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 19 Jan 2025 17:47:58 -0500 (EST) Message-ID: <42388479-bf5c-4836-b40f-d3967f5dfd1d@bsbernd.com> Date: Sun, 19 Jan 2025 23:47:58 +0100 Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 06/17] fuse: {io-uring} Handle SQEs - register commands To: Pavel Begunkov , Bernd Schubert , Miklos Szeredi Cc: Jens Axboe , linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, Joanne Koong , Josef Bacik , Amir Goldstein , Ming Lei , David Wei References: <20250107-fuse-uring-for-6-10-rfc4-v9-0-9c786f9a7a9d@ddn.com> <20250107-fuse-uring-for-6-10-rfc4-v9-6-9c786f9a7a9d@ddn.com> From: Bernd Schubert Content-Language: en-US, de-DE, fr In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 1/17/25 12:06, Pavel Begunkov wrote: > On 1/7/25 00:25, Bernd Schubert wrote: >> This adds basic support for ring SQEs (with opcode=IORING_OP_URING_CMD). >> For now only FUSE_IO_URING_CMD_REGISTER is handled to register queue >> entries. >> >> Signed-off-by: Bernd Schubert >> --- > ... > > Apart from mentioned by others and the comment below lgtm > > Reviewed-by: Pavel Begunkov > > >> diff --git a/fs/fuse/dev_uring.c b/fs/fuse/dev_uring.c >> new file mode 100644 >> index >> 0000000000000000000000000000000000000000..b44ba4033615e01041313c040035b6da6af0ee17 >> --- /dev/null >> +++ b/fs/fuse/dev_uring.c >> @@ -0,0 +1,333 @@ > ...> +/* Register header and payload buffer with the kernel and fetch a > request */ >> +static int fuse_uring_register(struct io_uring_cmd *cmd, >> +                   unsigned int issue_flags, struct fuse_conn *fc) >> +{ >> +    const struct fuse_uring_cmd_req *cmd_req = io_uring_sqe_cmd(cmd- >> >sqe); >> +    struct fuse_ring *ring = fc->ring; >> +    struct fuse_ring_queue *queue; >> +    struct fuse_ring_ent *ring_ent; >> +    int err; >> +    struct iovec iov[FUSE_URING_IOV_SEGS]; >> +    unsigned int qid = READ_ONCE(cmd_req->qid); >> + >> +    err = fuse_uring_get_iovec_from_sqe(cmd->sqe, iov); > > Looks like leftovers? Not used, and it's repeated in > fuse_uring_create_ring_ent(). Yep, thank you fixed. I hope there is nothing like that left anymore. I run static analyzers today - nothing found. Thanks, Bernd