public inbox for [email protected]
 help / color / mirror / Atom feed
* [PATCH for-5.20] io_uring/net: use right helpers for async_data
@ 2022-08-18 11:38 Pavel Begunkov
  2022-08-18 13:27 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Pavel Begunkov @ 2022-08-18 11:38 UTC (permalink / raw)
  To: io-uring; +Cc: Jens Axboe, asml.silence

There is another spot where we check ->async_data directly instead of
using req_has_async_data(), which is the way to do it, fix it up.

Fixes: 43e0bbbd0b0e3 ("io_uring: add netmsg cache")
Signed-off-by: Pavel Begunkov <[email protected]>
---
 io_uring/net.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/io_uring/net.c b/io_uring/net.c
index f7cbd716817f..f8cdf1dc3863 100644
--- a/io_uring/net.c
+++ b/io_uring/net.c
@@ -152,9 +152,9 @@ static int io_setup_async_msg(struct io_kiocb *req,
 			      struct io_async_msghdr *kmsg,
 			      unsigned int issue_flags)
 {
-	struct io_async_msghdr *async_msg = req->async_data;
+	struct io_async_msghdr *async_msg;
 
-	if (async_msg)
+	if (req_has_async_data(req))
 		return -EAGAIN;
 	async_msg = io_recvmsg_alloc_async(req, issue_flags);
 	if (!async_msg) {
-- 
2.37.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH for-5.20] io_uring/net: use right helpers for async_data
  2022-08-18 11:38 [PATCH for-5.20] io_uring/net: use right helpers for async_data Pavel Begunkov
@ 2022-08-18 13:27 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2022-08-18 13:27 UTC (permalink / raw)
  To: asml.silence, io-uring

On Thu, 18 Aug 2022 12:38:34 +0100, Pavel Begunkov wrote:
> There is another spot where we check ->async_data directly instead of
> using req_has_async_data(), which is the way to do it, fix it up.
> 
> 

Applied, thanks!

[1/1] io_uring/net: use right helpers for async_data
      commit: 3f743e9bbb8fe20f4c477e4bf6341c4187a4a264

Best regards,
-- 
Jens Axboe



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-08-18 13:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-18 11:38 [PATCH for-5.20] io_uring/net: use right helpers for async_data Pavel Begunkov
2022-08-18 13:27 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox