From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1347C3F2CD for ; Fri, 28 Feb 2020 14:26:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8891C2469F for ; Fri, 28 Feb 2020 14:26:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="sfTx6UED" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726845AbgB1O0f (ORCPT ); Fri, 28 Feb 2020 09:26:35 -0500 Received: from mail-io1-f68.google.com ([209.85.166.68]:39384 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726738AbgB1O0f (ORCPT ); Fri, 28 Feb 2020 09:26:35 -0500 Received: by mail-io1-f68.google.com with SMTP id h3so3575743ioj.6 for ; Fri, 28 Feb 2020 06:26:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=Hmi5le44CQGwHZkkTL72nRXhpJhZ7lPRnGWjBH7JO1M=; b=sfTx6UEDp6jly1gWp413OHU4NBU0yLUmZSFdVEtigbJuYIxiT0ZcQet1qkwiKWAsN6 ZwX73MDmY3TVBslM2YEoQ7CeebPykjbnQR/2K4BhlPuaXL1PR207IEVop5MoONHgs3F7 xfWzUd+sKOtHbYGzATpBJEBrYslZuHHB34zAXL1swPoh/3aeO1aD2wut8A0WYPfwmz3l a3kDbNcYhshGGslRLREFhTI/qyyCeOlGOmP5/62DHnvnQ+BDU/uksO6XK0R1/a58Yj3l DXK58/e3qqVAL8AtUlAeiKcWuFWVblazb1lo8twdJ5KYgN9rr5EfZEQXpy9zeeV77Gqr 8t8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Hmi5le44CQGwHZkkTL72nRXhpJhZ7lPRnGWjBH7JO1M=; b=ijuEStYBxLmtao9rIva2c7TRsRpH8vdpuufdmSHSgIlTAtWnxTOivds724u1pHVKhq ptcWp2BVj2E1bzMRX7WnFE+AncorUXhgsVDTXgQMfmtSUJKvLxGOtxxU7bLe96c9P2Vp py6+E1xYeT+OcM8nN8YZjuW4J/0byCPUz2lIpIRu6TGfZTmXxmo4WiMjEzo9B1dnB1yd B1RsJCgHUhtXZyCkkaGL/FFQy99QN15C1+ObZpybEFxXJPlOaPB2Mt5hhoKelheMcnlT lriTJqzA7PKyUSVevz6KbxJcTMIOfC3ajujm3cVWQYg6qCZTjkP4g9mikjxgalOZZlJ+ WB/Q== X-Gm-Message-State: APjAAAUjaHtNDG/kSuYN6ZivpiebmUzsB5VEXSzSgjfI2S154/AnXrQg PtEQxitKEBMbbVrFJJcNEbVOm0TwIS0= X-Google-Smtp-Source: APXvYqwKE8S55tXWujXu74z/WrxCIhadSvN6bbCm06hlROjJQJMP7kzYGjmY4S46oUFEHpb8rfRG6A== X-Received: by 2002:a5d:984e:: with SMTP id p14mr3823286ios.115.1582899993200; Fri, 28 Feb 2020 06:26:33 -0800 (PST) Received: from [192.168.1.159] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id n80sm3138915ilh.30.2020.02.28.06.26.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Feb 2020 06:26:32 -0800 (PST) Subject: Re: [PATCH 0/5] random io-wq and io_uring bits To: Pavel Begunkov , io-uring@vger.kernel.org References: From: Jens Axboe Message-ID: <43a706cf-0abb-94bf-1417-8bb73048fd09@kernel.dk> Date: Fri, 28 Feb 2020 07:26:32 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: io-uring-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 2/28/20 12:36 AM, Pavel Begunkov wrote: > A bunch of unconnected patches, easy and straightworward. > Probably could even be picked separately. > > The only thing could be of concern is [PATCH 4/5]. I assumed that > work setup is short (switch creds, mm, fs, files with task_[un]lock), > and arm a timeout after it's done. > > Pavel Begunkov (5): > io_uring: clean io_poll_complete > io_uring: extract kmsg copy helper > io-wq: remove unused IO_WQ_WORK_HAS_MM > io_uring: remove IO_WQ_WORK_CB > io-wq: use BIT for ulong hash > > fs/io-wq.c | 11 +++-------- > fs/io-wq.h | 2 -- > fs/io_uring.c | 51 +++++++++++++++++++++------------------------------ > 3 files changed, 24 insertions(+), 40 deletions(-) LGTM, and always love a negative diffstat. Applied for 5.7. -- Jens Axboe