From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71062C433ED for ; Fri, 16 Apr 2021 14:46:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 41F0A610FC for ; Fri, 16 Apr 2021 14:46:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245265AbhDPOqu (ORCPT ); Fri, 16 Apr 2021 10:46:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244605AbhDPOqt (ORCPT ); Fri, 16 Apr 2021 10:46:49 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8AC29C061574 for ; Fri, 16 Apr 2021 07:46:22 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id r7so14951971wrm.1 for ; Fri, 16 Apr 2021 07:46:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0EnohyU/dIJf9UEfukOwXCmBWlSvMXj167s2/zBlTa8=; b=VDBpxbzTmi/JFFhyzAvfP7/yYWXjsughrNok0rarLHmxdfKkyuERw8Qn3EmbFOSFkk 3tGwRyW4Q28Tk2dYVWjG1s+kb3qvvWuIdWjIP2Npjx3UJu/NY74AdafGSrEK+qe0KXyz G/CRO7P5eP81WNIuZU5QxELk+ENQqdMOAZfFcjuTVhi3QyCZnOkxr7+BvydPchmuy74r mhiBKBuS0ZhVW6MLsxlpVO8AKy6NZFmjWFKoJCyuf4Ps+o39rXEi09gg6IpHbd5TMYLG i6cF7SFnQ3XtUHhrGE5WBvWDHBS+8k2rlpXTEipKZNq0wC+LT64aE6Qf/AhYlN8NreGd eOag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=0EnohyU/dIJf9UEfukOwXCmBWlSvMXj167s2/zBlTa8=; b=gjiglOaFaRmaAdj7XpYDkVUdqus6QgqgLbtEJq56ygc0RJ92EMQiy6N2sUgY450sxZ RClYIdwoz3r2H/bytEm54vrBvKIGH8WbN2Zc4Kn71fjVxmWO1wWO9TihfxYTjLimu08Y tHeo1pUiHH87bScYyB1oMD+vBesvRdPCn9eJMzMpym6HKLIE3M6SxU6U75d0AjBuYFLE vkH2Ti1yxNsIvY1pB9yZxSZgtEZHeFKuH3VOPlPeVf1yXiXOMgjmqio8yQYsX+YNpQ5v DoEYSzfBpsNcXQ/qzDhsPT909GB0SvYoaKa5huIPKpOnvEX6Gc0clpylv6vbqlF1nWwl U5uA== X-Gm-Message-State: AOAM533rq4/X+zU0nvOQV1EqIGMxJfy7eTZn7JhGr9uE880HbeCWaJSx 6HIdoCWKSY2P4dGwK/rjsbA= X-Google-Smtp-Source: ABdhPJzFMyY9J6Euc5xSidSSmoDtpIsXjFer5uDyUaXXnkZ6zfwfpF1zEnl+WKX993aNA1x8OJk7CA== X-Received: by 2002:a5d:5711:: with SMTP id a17mr9597057wrv.342.1618584381341; Fri, 16 Apr 2021 07:46:21 -0700 (PDT) Received: from [192.168.8.191] ([148.252.132.77]) by smtp.gmail.com with ESMTPSA id s64sm9592428wmf.2.2021.04.16.07.46.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Apr 2021 07:46:21 -0700 (PDT) Subject: Re: [PATCH 0/2] fix hangs with shared sqpoll From: Pavel Begunkov To: Jens Axboe , io-uring@vger.kernel.org Cc: Dennis Zhou , Tejun Heo , Christoph Lameter , Joakim Hassila References: <8d04fa58-d8d0-8760-a6aa-d2bd6d66d09d@gmail.com> <36df5986-0716-b7e7-3dac-261a483d074a@kernel.dk> <1c26a568-e532-0987-158a-4cad6195f284@gmail.com> Autocrypt: addr=asml.silence@gmail.com; prefer-encrypt=mutual; keydata= mQINBFmKBOQBEAC76ZFxLAKpDw0bKQ8CEiYJRGn8MHTUhURL02/7n1t0HkKQx2K1fCXClbps bdwSHrhOWdW61pmfMbDYbTj6ZvGRvhoLWfGkzujB2wjNcbNTXIoOzJEGISHaPf6E2IQx1ik9 6uqVkK1OMb7qRvKH0i7HYP4WJzYbEWVyLiAxUj611mC9tgd73oqZ2pLYzGTqF2j6a/obaqha +hXuWTvpDQXqcOZJXIW43atprH03G1tQs7VwR21Q1eq6Yvy2ESLdc38EqCszBfQRMmKy+cfp W3U9Mb1w0L680pXrONcnlDBCN7/sghGeMHjGKfNANjPc+0hzz3rApPxpoE7HC1uRiwC4et83 CKnncH1l7zgeBT9Oa3qEiBlaa1ZCBqrA4dY+z5fWJYjMpwI1SNp37RtF8fKXbKQg+JuUjAa9 Y6oXeyEvDHMyJYMcinl6xCqCBAXPHnHmawkMMgjr3BBRzODmMr+CPVvnYe7BFYfoajzqzq+h EyXSl3aBf0IDPTqSUrhbmjj5OEOYgRW5p+mdYtY1cXeK8copmd+fd/eTkghok5li58AojCba jRjp7zVOLOjDlpxxiKhuFmpV4yWNh5JJaTbwCRSd04sCcDNlJj+TehTr+o1QiORzc2t+N5iJ NbILft19Izdn8U39T5oWiynqa1qCLgbuFtnYx1HlUq/HvAm+kwARAQABtDFQYXZlbCBCZWd1 bmtvdiAoc2lsZW5jZSkgPGFzbWwuc2lsZW5jZUBnbWFpbC5jb20+iQJOBBMBCAA4FiEE+6Ju PTjTbx479o3OWt5b1Glr+6UFAlmKBOQCGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQ Wt5b1Glr+6WxZA//QueaKHzgdnOikJ7NA/Vq8FmhRlwgtP0+E+w93kL+ZGLzS/cUCIjn2f4Q Mcutj2Neg0CcYPX3b2nJiKr5Vn0rjJ/suiaOa1h1KzyNTOmxnsqE5fmxOf6C6x+NKE18I5Jy xzLQoktbdDVA7JfB1itt6iWSNoOTVcvFyvfe5ggy6FSCcP+m1RlR58XxVLH+qlAvxxOeEr/e aQfUzrs7gqdSd9zQGEZo0jtuBiB7k98t9y0oC9Jz0PJdvaj1NZUgtXG9pEtww3LdeXP/TkFl HBSxVflzeoFaj4UAuy8+uve7ya/ECNCc8kk0VYaEjoVrzJcYdKP583iRhOLlZA6HEmn/+Gh9 4orG67HNiJlbFiW3whxGizWsrtFNLsSP1YrEReYk9j1SoUHHzsu+ZtNfKuHIhK0sU07G1OPN 2rDLlzUWR9Jc22INAkhVHOogOcc5ajMGhgWcBJMLCoi219HlX69LIDu3Y34uIg9QPZIC2jwr 24W0kxmK6avJr7+n4o8m6sOJvhlumSp5TSNhRiKvAHB1I2JB8Q1yZCIPzx+w1ALxuoWiCdwV M/azguU42R17IuBzK0S3hPjXpEi2sK/k4pEPnHVUv9Cu09HCNnd6BRfFGjo8M9kZvw360gC1 reeMdqGjwQ68o9x0R7NBRrtUOh48TDLXCANAg97wjPoy37dQE7e5Ag0EWYoE5AEQAMWS+aBV IJtCjwtfCOV98NamFpDEjBMrCAfLm7wZlmXy5I6o7nzzCxEw06P2rhzp1hIqkaab1kHySU7g dkpjmQ7Jjlrf6KdMP87mC/Hx4+zgVCkTQCKkIxNE76Ff3O9uTvkWCspSh9J0qPYyCaVta2D1 Sq5HZ8WFcap71iVO1f2/FEHKJNz/YTSOS/W7dxJdXl2eoj3gYX2UZNfoaVv8OXKaWslZlgqN jSg9wsTv1K73AnQKt4fFhscN9YFxhtgD/SQuOldE5Ws4UlJoaFX/yCoJL3ky2kC0WFngzwRF Yo6u/KON/o28yyP+alYRMBrN0Dm60FuVSIFafSqXoJTIjSZ6olbEoT0u17Rag8BxnxryMrgR dkccq272MaSS0eOC9K2rtvxzddohRFPcy/8bkX+t2iukTDz75KSTKO+chce62Xxdg62dpkZX xK+HeDCZ7gRNZvAbDETr6XI63hPKi891GeZqvqQVYR8e+V2725w+H1iv3THiB1tx4L2bXZDI DtMKQ5D2RvCHNdPNcZeldEoJwKoA60yg6tuUquvsLvfCwtrmVI2rL2djYxRfGNmFMrUDN1Xq F3xozA91q3iZd9OYi9G+M/OA01husBdcIzj1hu0aL+MGg4Gqk6XwjoSxVd4YT41kTU7Kk+/I 5/Nf+i88ULt6HanBYcY/+Daeo/XFABEBAAGJAjYEGAEIACAWIQT7om49ONNvHjv2jc5a3lvU aWv7pQUCWYoE5AIbDAAKCRBa3lvUaWv7pfmcEACKTRQ28b1y5ztKuLdLr79+T+LwZKHjX++P 4wKjEOECCcB6KCv3hP+J2GCXDOPZvdg/ZYZafqP68Yy8AZqkfa4qPYHmIdpODtRzZSL48kM8 LRzV8Rl7J3ItvzdBRxf4T/Zseu5U6ELiQdCUkPGsJcPIJkgPjO2ROG/ZtYa9DvnShNWPlp+R uPwPccEQPWO/NP4fJl2zwC6byjljZhW5kxYswGMLBwb5cDUZAisIukyAa8Xshdan6C2RZcNs rB3L7vsg/R8UCehxOH0C+NypG2GqjVejNZsc7bgV49EOVltS+GmGyY+moIzxsuLmT93rqyII 5rSbbcTLe6KBYcs24XEoo49Zm9oDA3jYvNpeYD8rDcnNbuZh9kTgBwFN41JHOPv0W2FEEWqe JsCwQdcOQ56rtezdCJUYmRAt3BsfjN3Jn3N6rpodi4Dkdli8HylM5iq4ooeb5VkQ7UZxbCWt UVMKkOCdFhutRmYp0mbv2e87IK4erwNHQRkHUkzbsuym8RVpAZbLzLPIYK/J3RTErL6Z99N2 m3J6pjwSJY/zNwuFPs9zGEnRO4g0BUbwGdbuvDzaq6/3OJLKohr5eLXNU3JkT+3HezydWm3W OPhauth7W0db74Qd49HXK0xe/aPrK+Cp+kU1HRactyNtF8jZQbhMCC8vMGukZtWaAwpjWiiH bA== Message-ID: <43f206ad-8ebb-bff1-348f-ae5dbda04f13@gmail.com> Date: Fri, 16 Apr 2021 15:42:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <1c26a568-e532-0987-158a-4cad6195f284@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 16/04/2021 15:09, Pavel Begunkov wrote: > On 16/04/2021 14:58, Jens Axboe wrote: >> On 4/16/21 7:12 AM, Pavel Begunkov wrote: >>> On 16/04/2021 14:04, Jens Axboe wrote: >>>> On 4/15/21 6:26 PM, Pavel Begunkov wrote: >>>>> On 16/04/2021 01:22, Pavel Begunkov wrote: >>>>>> Late catched 5.12 bug with nasty hangs. Thanks Jens for a reproducer. >>>>> >>>>> 1/2 is basically a rip off of one of old Jens' patches, but can't >>>>> find it anywhere. If you still have it, especially if it was >>>>> reviewed/etc., may make sense to go with it instead >>>> >>>> I wonder if we can do something like the below instead - we don't >>>> care about a particularly stable count in terms of wakeup >>>> reliance, and it'd save a nasty sync atomic switch. >>> >>> But we care about it being monotonous. There are nuances with it. >> >> Do we, though? We care about it changing when something has happened, >> but not about it being monotonic. > > We may find inflight == get_inflight(), when it's not really so, > and so get to schedule() awhile there are pending requests that > are not going to be cancelled by itself. And those pending requests > may have been non-discoverable and so non-cancellable, e.g. because > were a part of a ling/hardlink. Anyway, there might be other problems because of how wake_up()'s and ctx->refs putting is ordered. Needs to be remade, probably without ctx->refs in the first place. >>> I think, non sync'ed summing may put it to eternal sleep. >> >> That's what the two reads are about, that's the same as before. The >> numbers are racy in both cases, but that's why we compare after having >> added ourselves to the wait queue. >> >>> Are you looking to save on switching? It's almost always is already >>> dying with prior ref_kill >> >> Yep, always looking to avoid a sync switch if at all possible. For 99% >> of the cases it's fine, it's the last case in busy prod that wreaks >> havoc. > > Limited to sqpoll, so I wouldn't worry. Also considering that sqpoll > doesn't have many file notes (as it was called before). We can > completely avoid it and even make faster if happens from sq_thread() > on it getting to exit, but do we want it for 5.12? > -- Pavel Begunkov