* [PATCH][TRIVIAL] io_uring: fix four comment typos
@ 2025-06-27 23:27 Andrew Bernal
2025-06-28 15:06 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Bernal @ 2025-06-27 23:27 UTC (permalink / raw)
To: io-uring; +Cc: axboe, trivial, Andrew Bernal
Fix minor spelling mistakes in io_uring.c:
- cancelation -> cancellation
- reuqests -> requests
- discernable -> discernible
- cancelations -> cancellations
Signed-off-by: Andrew Bernal <andrewlbernal@gmail.com>
---
io_uring/io_uring.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c
index 5111ec040c53..6fe489d6ae83 100644
--- a/io_uring/io_uring.c
+++ b/io_uring/io_uring.c
@@ -409,7 +409,7 @@ static void io_clean_op(struct io_kiocb *req)
}
/*
- * Mark the request as inflight, so that file cancelation will find it.
+ * Mark the request as inflight, so that file cancellation will find it.
* Can be used if the file is an io_uring instance, or if the request itself
* relies on ->mm being alive for the duration of the request.
*/
@@ -1162,7 +1162,7 @@ static void io_req_local_work_add(struct io_kiocb *req, unsigned flags)
BUILD_BUG_ON(IO_CQ_WAKE_FORCE <= IORING_MAX_CQ_ENTRIES);
/*
- * We don't know how many reuqests is there in the link and whether
+ * We don't know how many requests is there in the link and whether
* they can even be queued lazily, fall back to non-lazy.
*/
if (req->flags & IO_REQ_LINK_FLAGS)
@@ -2856,7 +2856,7 @@ static __cold void io_tctx_exit_cb(struct callback_head *cb)
* When @in_cancel, we're in cancellation and it's racy to remove the
* node. It'll be removed by the end of cancellation, just ignore it.
* tctx can be NULL if the queueing of this task_work raced with
- * work cancelation off the exec path.
+ * work cancellation off the exec path.
*/
if (tctx && !atomic_read(&tctx->in_cancel))
io_uring_del_tctx_node((unsigned long)work->ctx);
@@ -2988,7 +2988,7 @@ static __cold void io_ring_ctx_wait_and_kill(struct io_ring_ctx *ctx)
/*
* Use system_unbound_wq to avoid spawning tons of event kworkers
* if we're exiting a ton of rings at the same time. It just adds
- * noise and overhead, there's no discernable change in runtime
+ * noise and overhead, there's no discernible change in runtime
* over using system_wq.
*/
queue_work(iou_wq, &ctx->exit_work);
@@ -3160,7 +3160,7 @@ __cold void io_uring_cancel_generic(bool cancel_all, struct io_sq_data *sqd)
if (!tctx_inflight(tctx, !cancel_all))
break;
- /* read completions before cancelations */
+ /* read completions before cancellations */
inflight = tctx_inflight(tctx, false);
if (!inflight)
break;
--
2.49.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][TRIVIAL] io_uring: fix four comment typos
2025-06-27 23:27 [PATCH][TRIVIAL] io_uring: fix four comment typos Andrew Bernal
@ 2025-06-28 15:06 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2025-06-28 15:06 UTC (permalink / raw)
To: Andrew Bernal, io-uring; +Cc: trivial
On 6/27/25 5:27 PM, Andrew Bernal wrote:
> Fix minor spelling mistakes in io_uring.c:
> - cancelation -> cancellation
> - reuqests -> requests
> - discernable -> discernible
> - cancelations -> cancellations
As I've replied on this list before, cancelation is a perfectly
cromulent spelling. For the rest, not sure it's worth it. And:
> @@ -1162,7 +1162,7 @@ static void io_req_local_work_add(struct io_kiocb *req, unsigned flags)
> BUILD_BUG_ON(IO_CQ_WAKE_FORCE <= IORING_MAX_CQ_ENTRIES);
>
> /*
> - * We don't know how many reuqests is there in the link and whether
> + * We don't know how many requests is there in the link and whether
> * they can even be queued lazily, fall back to non-lazy.
> */
> if (req->flags & IO_REQ_LINK_FLAGS)
mechanical changes like this that don't even look at the sentence
(there's more to correct here...) are certainly less worthwhile than
making it more coherent in general.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-28 15:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-27 23:27 [PATCH][TRIVIAL] io_uring: fix four comment typos Andrew Bernal
2025-06-28 15:06 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox