From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6443C4338F for ; Mon, 23 Aug 2021 12:33:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A3AD560FD9 for ; Mon, 23 Aug 2021 12:33:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235641AbhHWMeZ (ORCPT ); Mon, 23 Aug 2021 08:34:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233755AbhHWMeZ (ORCPT ); Mon, 23 Aug 2021 08:34:25 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF2D4C061575; Mon, 23 Aug 2021 05:33:42 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id f5so25981926wrm.13; Mon, 23 Aug 2021 05:33:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:references:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=OjHKIyDp4qePWShFpyJDu3Saj28KE1lZFBDHFnUTieo=; b=shPp16gQBf4q+RE6TMLBi6l1jvMeTTJ4GmUQyAGYLX8O6cZNwjy2ZIFMiNLgwJfx7G 9T0F07Jfby2bNZseXwfnNkqfECqir9V7CkaFT9MR2O7V3WrjV8LH1Qmi6KiRhyNy0Qlb GED331RZvDrplT0EA5yCMC+G78CaiyRLHqohQagzb+Tr09Z77bBCZHLbe0VIKB2jd3Zm 2ZLMcfA7phkcwdTA0r8S6lKRM8NkKoPc4vRIzh0R2liflXJMq672v/DqXZSak19ZRkfg rIwVM+udU7myjH6/2nIDZofUF+C6od7um0lC9kkkqfj63GffExs2IfLedShNo4eD0QKk BC1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OjHKIyDp4qePWShFpyJDu3Saj28KE1lZFBDHFnUTieo=; b=im5GyGYStjL305bQkgbf1LX6RI+biCsdp6u7IFeleviIVCibQHW30m2v68bRS2Nhcp bYB+jOgY7V6oVrq8OeJTq6C54R1z0+TbHk6xREUlvI/EFEZfftVXr9qIp8vGzKl9WzqZ CXpJKmNXlpwL/r+lvyLO1dpUYi8GEKSpW/0WBjJekxaw8R8BE4HPeaMY8x0DnsTh5tOh 8faaxQnlH7xKS47DBaPcBdAbkSSru1fxMnFjmzMjZX5O3hH85W+iFElqArnqifKNAenY jHaaXZGVjObZQ8uIhzzoBAsogCLZX0oimfzC6JHCxd4hGkL+ZV57RWVhtWQ2lkoX5p2R cedw== X-Gm-Message-State: AOAM5327b1FGswK8ikOrqLPdm2NRIzoqChC5yWfkiwDRYce5ZCt7s9X9 pycbqNs5KTpaYS2bUIYzvjc= X-Google-Smtp-Source: ABdhPJxY2bkHYPxNWwSY7NCHAqdN71l1Xc98kdN9thdICu0tZ+USlK3PGo0IhCj+9vKKqBl9AFLTiw== X-Received: by 2002:a5d:58e9:: with SMTP id f9mr7741113wrd.154.1629722021381; Mon, 23 Aug 2021 05:33:41 -0700 (PDT) Received: from [192.168.8.197] ([85.255.233.176]) by smtp.gmail.com with ESMTPSA id h6sm14795848wmq.5.2021.08.23.05.33.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Aug 2021 05:33:41 -0700 (PDT) Subject: Re: [syzbot] WARNING in io_try_cancel_userdata From: Pavel Begunkov To: syzbot , axboe@kernel.dk, io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com References: <000000000000dd79fc05ca367b9d@google.com> Message-ID: <475c86fb-fe3c-7e68-b115-adf71cf63c27@gmail.com> Date: Mon, 23 Aug 2021 13:33:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 8/23/21 12:36 PM, Pavel Begunkov wrote: > On 8/23/21 10:17 AM, syzbot wrote: >> Hello, >> >> syzbot found the following issue on: >> >> HEAD commit: 86ed57fd8c93 Add linux-next specific files for 20210820 >> git tree: linux-next >> console output: https://syzkaller.appspot.com/x/log.txt?x=1565bd55300000 >> kernel config: https://syzkaller.appspot.com/x/.config?x=f64eccb415bd479d >> dashboard link: https://syzkaller.appspot.com/bug?extid=b0c9d1588ae92866515f >> compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.1 >> >> Unfortunately, I don't have any reproducer for this issue yet. >> >> IMPORTANT: if you fix the issue, please add the following tag to the commit: >> Reported-by: syzbot+b0c9d1588ae92866515f@syzkaller.appspotmail.com > > false positive, will delete the warning with explanation There is a legit race though, a fix is sent. > > p.s. easily reproducible, we'll add a test covering cancel from io-wq > >> >> WARNING: CPU: 1 PID: 5870 at fs/io_uring.c:5975 io_try_cancel_userdata+0x30f/0x540 fs/io_uring.c:5975 >> Modules linked in: >> CPU: 0 PID: 5870 Comm: iou-wrk-5860 Not tainted 5.14.0-rc6-next-20210820-syzkaller #0 >> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 >> RIP: 0010:io_try_cancel_userdata+0x30f/0x540 fs/io_uring.c:5975 >> Code: 07 e8 e5 9d 95 ff 48 8b 7c 24 08 e8 ab 02 58 07 e9 6f fe ff ff e8 d1 9d 95 ff 41 bf 8e ff ff ff e9 5f fe ff ff e8 c1 9d 95 ff <0f> 0b 48 b8 00 00 00 00 00 fc ff df 4c 89 fa 48 c1 ea 03 80 3c 02 >> RSP: 0018:ffffc900055f7a88 EFLAGS: 00010293 >> RAX: 0000000000000000 RBX: ffff888181aa83c0 RCX: 0000000000000000 >> RDX: ffff88803fb88000 RSI: ffffffff81e0dacf RDI: ffff888181aa8410 >> RBP: ffff88803fb88000 R08: ffffffff899ad660 R09: ffffffff81e23c44 >> R10: 0000000000000027 R11: 000000000000000e R12: 1ffff92000abef53 >> R13: 0000000000000000 R14: ffff8880b34d0000 R15: ffff888181aa8420 >> FS: 00007f7a08d50700(0000) GS:ffff8880b9d00000(0000) knlGS:0000000000000000 >> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >> CR2: 0000001b2c72e000 CR3: 0000000168b9b000 CR4: 00000000001506e0 >> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 >> DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000600 >> Call Trace: >> io_async_cancel fs/io_uring.c:6014 [inline] >> io_issue_sqe+0x22d5/0x65a0 fs/io_uring.c:6407 >> io_wq_submit_work+0x1dc/0x300 fs/io_uring.c:6511 >> io_worker_handle_work+0xa45/0x1840 fs/io-wq.c:533 >> io_wqe_worker+0x2cc/0xbb0 fs/io-wq.c:582 >> ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:295 >> >> >> --- >> This report is generated by a bot. It may contain errors. >> See https://goo.gl/tpsmEJ for more information about syzbot. >> syzbot engineers can be reached at syzkaller@googlegroups.com. >> >> syzbot will keep track of this issue. See: >> https://goo.gl/tpsmEJ#status for how to communicate with syzbot. >> > -- Pavel Begunkov