public inbox for [email protected]
 help / color / mirror / Atom feed
* [PATCH] io_uring/fs: remove sqe->rw_flags checking from LINKAT
@ 2023-09-28 15:28 Jens Axboe
  0 siblings, 0 replies; only message in thread
From: Jens Axboe @ 2023-09-28 15:28 UTC (permalink / raw)
  To: io-uring

This is unionized with the actual link flags, so they can of course be
set and they will be evaluated further down. If not we fail any LINKAT
that has to set option flags.

Fixes: cf30da90bc3a ("io_uring: add support for IORING_OP_LINKAT")
Cc: [email protected]
Link: https://github.com/axboe/liburing/issues/955
Signed-off-by: Jens Axboe <[email protected]>

---

diff --git a/io_uring/fs.c b/io_uring/fs.c
index f6a69a549fd4..08e3b175469c 100644
--- a/io_uring/fs.c
+++ b/io_uring/fs.c
@@ -243,7 +243,7 @@ int io_linkat_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe)
 	struct io_link *lnk = io_kiocb_to_cmd(req, struct io_link);
 	const char __user *oldf, *newf;
 
-	if (sqe->rw_flags || sqe->buf_index || sqe->splice_fd_in)
+	if (sqe->buf_index || sqe->splice_fd_in)
 		return -EINVAL;
 	if (unlikely(req->flags & REQ_F_FIXED_FILE))
 		return -EBADF;

-- 
Jens Axboe


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2023-09-28 15:28 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-28 15:28 [PATCH] io_uring/fs: remove sqe->rw_flags checking from LINKAT Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox