From: Jens Axboe <axboe@kernel.dk>
To: Caleb Sander Mateos <csander@purestorage.com>
Cc: io-uring@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot@syzkaller.appspotmail.com
Subject: Re: [PATCH v2 5/5] io_uring: avoid uring_lock for IORING_SETUP_SINGLE_ISSUER
Date: Mon, 8 Sep 2025 13:20:29 -0600 [thread overview]
Message-ID: <4812e4b2-b7e0-45e6-b465-e160ac267939@kernel.dk> (raw)
In-Reply-To: <20250904170902.2624135-6-csander@purestorage.com>
On 9/4/25 11:09 AM, Caleb Sander Mateos wrote:
> diff --git a/io_uring/io_uring.h b/io_uring/io_uring.h
> index a0580a1bf6b5..7296b12b0897 100644
> --- a/io_uring/io_uring.h
> +++ b/io_uring/io_uring.h
> @@ -121,20 +121,34 @@ bool io_match_task_safe(struct io_kiocb *head, struct io_uring_task *tctx,
>
> void io_activate_pollwq(struct io_ring_ctx *ctx);
>
> static inline void io_ring_ctx_lock(struct io_ring_ctx *ctx)
> {
> + if (ctx->flags & IORING_SETUP_SINGLE_ISSUER) {
> + WARN_ON_ONCE(current != ctx->submitter_task);
> + return;
> + }
> +
> mutex_lock(&ctx->uring_lock);
> }
>
> static inline void io_ring_ctx_unlock(struct io_ring_ctx *ctx)
> {
> + if (ctx->flags & IORING_SETUP_SINGLE_ISSUER) {
> + WARN_ON_ONCE(current != ctx->submitter_task);
> + return;
> + }
> +
> mutex_unlock(&ctx->uring_lock);
> }
I do want to get rid of these WARN_ON_ONCE() down the line, but it's
prudent to keep them there for now.
--
Jens Axboe
next prev parent reply other threads:[~2025-09-08 19:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 17:08 [PATCH v2 0/5] io_uring: avoid uring_lock for IORING_SETUP_SINGLE_ISSUER Caleb Sander Mateos
2025-09-04 17:08 ` [PATCH v2 1/5] io_uring: don't include filetable.h in io_uring.h Caleb Sander Mateos
2025-09-04 17:08 ` [PATCH v2 2/5] io_uring/rsrc: respect submitter_task in io_register_clone_buffers() Caleb Sander Mateos
2025-09-09 13:35 ` Jens Axboe
2025-09-04 17:09 ` [PATCH v2 3/5] io_uring: clear IORING_SETUP_SINGLE_ISSUER for IORING_SETUP_SQPOLL Caleb Sander Mateos
2025-09-08 14:13 ` Jens Axboe
2025-09-08 18:11 ` Caleb Sander Mateos
2025-09-08 19:19 ` Jens Axboe
2025-09-04 17:09 ` [PATCH v2 4/5] io_uring: factor out uring_lock helpers Caleb Sander Mateos
2025-09-04 17:09 ` [PATCH v2 5/5] io_uring: avoid uring_lock for IORING_SETUP_SINGLE_ISSUER Caleb Sander Mateos
2025-09-08 19:20 ` Jens Axboe [this message]
2025-09-09 13:35 ` [PATCH v2 0/5] " Jens Axboe
2025-09-10 11:57 ` Pavel Begunkov
2025-09-10 15:36 ` Jens Axboe
2025-09-11 10:36 ` Pavel Begunkov
2025-09-30 23:37 ` Caleb Sander Mateos
2025-11-03 20:47 ` Caleb Sander Mateos
2025-09-11 16:14 ` Caleb Sander Mateos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4812e4b2-b7e0-45e6-b465-e160ac267939@kernel.dk \
--to=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox