public inbox for io-uring@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Begunkov <asml.silence@gmail.com>
To: Pavel Begunkov <asml.silence@gmail.com>,
	io-uring <io-uring@vger.kernel.org>
Subject: Re: [PATCH 1/1] io_uring/zctx: check chained notif contexts
Date: Wed, 20 Aug 2025 20:03:05 +0100	[thread overview]
Message-ID: <4889b8bb-5f50-46a9-8cbc-b00013dc8dff@gmail.com> (raw)
In-Reply-To: <fd527d8638203fe0f1c5ff06ff2e1d8fd68f831b.1755179962.git.asml.silence@gmail.com>

On 8/14/25 15:40, Pavel Begunkov wrote:
> Send zc only links ubuf_info for requests coming from the same context.
> There are some ambiguous syz reports, so let's check the assumption on
> notification completion.

This one would be great to have to hopefully start tackling
the syzbot report.


> Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
> ---
>   io_uring/notif.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/io_uring/notif.c b/io_uring/notif.c
> index 9a6f6e92d742..8c92e9cde2c6 100644
> --- a/io_uring/notif.c
> +++ b/io_uring/notif.c
> @@ -14,10 +14,15 @@ static const struct ubuf_info_ops io_ubuf_ops;
>   static void io_notif_tw_complete(struct io_kiocb *notif, io_tw_token_t tw)
>   {
>   	struct io_notif_data *nd = io_notif_to_data(notif);
> +	struct io_ring_ctx *ctx = notif->ctx;
> +
> +	lockdep_assert_held(&ctx->uring_lock);
>   
>   	do {
>   		notif = cmd_to_io_kiocb(nd);
>   
> +		if (WARN_ON_ONCE(ctx != notif->ctx))
> +			return;
>   		lockdep_assert(refcount_read(&nd->uarg.refcnt) == 0);
>   
>   		if (unlikely(nd->zc_report) && (nd->zc_copied || !nd->zc_used))

-- 
Pavel Begunkov


  reply	other threads:[~2025-08-20 19:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-14 14:40 [PATCH 1/1] io_uring/zctx: check chained notif contexts Pavel Begunkov
2025-08-20 19:03 ` Pavel Begunkov [this message]
2025-08-20 19:05 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4889b8bb-5f50-46a9-8cbc-b00013dc8dff@gmail.com \
    --to=asml.silence@gmail.com \
    --cc=io-uring@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox